Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User gets credited twice for odd case #56

Open
ghost opened this issue May 8, 2014 · 0 comments
Open

User gets credited twice for odd case #56

ghost opened this issue May 8, 2014 · 0 comments

Comments

@ghost
Copy link

ghost commented May 8, 2014

From email:

 I would like to report a bug in the TMSC balance reporting for address 1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6, balance 0.101 which differs from MasterChest, balance 0.082. 

In both cases, the totals add up like so:
 "total_received": "0.12" + "total_bought": "0.004" - total_sent": "0.033" - "total_sold": "0.009" = 0.082

 The reported balance shows a difference of 0.101-0.082=0.019, which is the same available_amount of sell_offer f4d5e7a5af93b50... 

I looked through some debug and found a few odd things, would you happen to find any of this odd? I've highlighted relevant portions in bold.

Balance is credited for the  expired accept that was updated (reserved funds *not* changed)
 1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6 Test Mastercoin before alarm expired 
[D] debug_address: balance: 5100000
[D] debug_address: reserved: 2900000
[D] check_alarm: skip updating reserved on 1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6 as payment expired and it got already updated
1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6 Test Mastercoin after alarm expired 
[D] debug_address: balance: 7000000
[D] debug_address: reserved: 2900000
1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6 Test Mastercoin after alarm expired


And after the final sell cancel:
t1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6 Test Mastercoin before sell offer 
[D] debug_address: balance: 7000000
[D] debug_address: reserved: 2900000
1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6 Test Mastercoin before sell offer 
[D] check_mastercoin_transaction: [u'2ae17011888e9a2e6c752999774cd6d88feb7c0751abe72a602be89858e44f6a']
[D] check_mastercoin_transaction: accept_offer_running NOT exhausted
[D] check_mastercoin_transaction: accept already expired
[D] check_mastercoin_transaction: NO accept offer was running - add all reserved to balance
[D] debug_address: balance: 9900000
[D] debug_address: reserved: 0
1G3P5bws8wRVrVfKWxv8F85pRjs9qXyyA6 Test Mastercoin after sell offer 

It appears as though the seller address is credited twice with 0.019, can you confirm any of this behavior?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants