Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow/block list improvement: mns remove .massa if specified #89

Open
4 tasks
thomas-senechal opened this issue Aug 27, 2024 · 0 comments
Open
4 tasks
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@thomas-senechal
Copy link
Member

thomas-senechal commented Aug 27, 2024

Context
ATM, the DeWeb server config file only handles addresses and MNS domains without the ".massa". We should improve this system to remove the ".massa" before storing in memory, if specified by users.

How to

In MNS pkg

  • Implement a function that:
    • takes a list of strings
    • returns a list of string
    • check every strings from the input and removes ".massa" suffix
    • returns the modified list
  • Implement tests to ensure this is working properly

In API config

  • Use this function in API config load
  • Test the changes
@thomas-senechal thomas-senechal added enhancement New feature or request good first issue Good for newcomers labels Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants