-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sign-all=true
doesn't sign commits authored by someone else
#4561
Comments
I think the current behavior is by design, and this use case will be handled by |
That's a bit surprising. First, git with https://github.com/martinvonz/jj/blob/main/docs/config.md#commit-signing
I can see how you could maybe interpret this to mean it only signs new commits (as in, created with Also, the argument was made that people are gonna want the "Verified" chip on Github. I'm one of those people. :) |
cc @necauqua (I agree the doc is unclear.) |
Huh, I'm pretty sure that by that design point 2 should've failed to complete, since the idea was that automatically rewriting and resigning someone elses commits may be undesirable. Oh, maybe that other commit was not signed, and we just don't sign it too then?. That does sound weird. I need to revisit it all, was a while, I'll come back later |
Description
With
signing.sign-all = true
, jj does not sign commits that someone else originally authored, after I made changes to them (like editing the description).Steps to Reproduce the Problem
jj config set --user signing.sign-all true
git log -1 --format=fuller --show-signature `jj log --no-graph -r@ -Tcommit_id`
Expected Behavior
The commit is signed (with my key, as I am the Committer)
Actual Behavior
The commit is not signed
Specifications
The text was updated successfully, but these errors were encountered: