Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ACR support removed? #279

Open
z3ntu opened this issue Oct 27, 2021 · 1 comment
Open

ACR support removed? #279

z3ntu opened this issue Oct 27, 2021 · 1 comment

Comments

@z3ntu
Copy link

z3ntu commented Oct 27, 2021

Hi, I've noticed that in recent versions the ACR support was removed, gp -acr-add, gp -acr-delete, gp -acr-list-aram and friends. I've found commit e41c8e9 but the repository linked there (https://github.com/martinpaljak/seac) doesn't exist.

ACR support from v20.04.14 works pretty well, just -acr-delete needs a small fix to work

diff --git a/tool/src/main/java/pro/javacard/gp/GPTool.java b/tool/src/main/java/pro/javacard/gp/GPTool.java
index 68fea41..c06969b 100644
--- a/tool/src/main/java/pro/javacard/gp/GPTool.java
+++ b/tool/src/main/java/pro/javacard/gp/GPTool.java
@@ -564,7 +564,7 @@ public final class GPTool extends GPCommandLineInterface {
 
                     AID aid = null;
                     if (args.has(OPT_APPLET)) {
-                        aid = AID.fromString(OPT_APPLET);
+                        aid = AID.fromString(args.valueOf(OPT_APPLET));
                     }
 
                     byte[] hash = null;
@z3ntu
Copy link
Author

z3ntu commented Oct 12, 2022

Also linking my branch that adds PERM_AR_DO support, not super pretty commits as I doubt there's any chance this can get merged, given that ACR support has been removed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant