Script inserts missing thead and may move first tr #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script works just the same as before by default but now if there is no thead element a thead is inserted and the first row is moved into the thead element. This allows the script to work in places where a proper thead may not be generated.
|
I made this because I was trying to get this to work in Confluence. Confluence does not actually have a thead element in it's rendering of the wiki. This fix really helped solve the issue and I think it's a simple change. It may not play nice with some of the other outstanding merge requests (like multiple header rows) so let me know if you want me to rebase off of any of those first.. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script works just the same as before by default but now if there is
no thead element, a thead is inserted and the first row found is moved into the
thead element. This allows the script to work in places where a proper
thead may not be generated.