Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event namespace missing! Serious errors occurs when used on multiple containers. #149

Open
retan opened this issue Mar 26, 2017 · 0 comments

Comments

@retan
Copy link

retan commented Mar 26, 2017

There's a quite serious error in the code (it made me loose last 3 hours).
The plugin is attaching event handlers without namespace!
It's clearly intended to use namespace but...
in init function:

this.options.name = pluginName + '_' + Math.floor(Math.random() * 1e9);

and afterwards everywhere it uses this.name (not this.options.name), e.g.:

$window.bind('load.' + this.name, function() {

To minimize the modifications, I've changed the line in the init function to:

this.name = pluginName + '_' + Math.floor(Math.random() * 1e9);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant