Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not log secret #6

Open
pstoll opened this issue Feb 9, 2017 · 1 comment
Open

Do not log secret #6

pstoll opened this issue Feb 9, 2017 · 1 comment

Comments

@pstoll
Copy link

pstoll commented Feb 9, 2017

In both decrypt.js and encrypt.js, the secret text is sent to the logger facility. Is this really necessary? It seems to reduce the security of the secrets - let the caller decide if they want to log this info. I'd suggest you ought to not log the decrypted secret in those two cases.
@firojasha
Copy link

Yes, i agree this its valid point, can we have not show the secret text in logger? please check this once?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pstoll @firojasha