Update from upstream repo wix/react-templates #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Single child for rt-template (fixes #138) * Nested scope functions (fixes #139) * Forbid nested rt-import (fixes #134) * Vendor prefixes style keys (#144) * Renamed test file * Forbid expressions in style keys (#145) * fixed rt-import and AMD (#147) * Updated documentation * Fixed links in README.md * Sanitize comments (fix #158) * Disable comments when es6 (fix#157) * Added test case for comments * Simplified TypeScript output * Test cases for simplified TypeScript output * Fixed wrong TypeScript output (#161) * fix repeat with custom index (#162)
* Clean up the list of propTemplates fixtures. * Subtract the child index of a rt-template tag by the number of rt-template tags seen. Fixes #163.
minor fixes
Fixed html tests that were not running due to changed file name. Failing html tests now dump "actual" html instead of the code that generates it (.actual.html) Fixed title for rtStyle tests Removed compareAndWriteHtml() that is no longer needed
Also, added `rt-virtual` to list of `Built-in directives`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
The remote
wix/react-templateshas some new changes that aren't in this fork.So, here they are, ready to be merged! 🎉
If this pull request can be merged without conflict, you can publish your software
with these new changes. Otherwise, if you have merge conflicts, this
is the place to fix them.
Have fun! 👋
From,
🏊 Your Neighborly Backstroke Bot
PS. Hey, there's a new version of Backstroke available. If you'd like to configure repo-to-repo syncing or sync to all forks, check it out here.