Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify rich text attachment workflow #100

Open
goldpbear opened this issue Nov 15, 2017 · 2 comments
Open

Simplify rich text attachment workflow #100

goldpbear opened this issue Nov 15, 2017 · 2 comments
Assignees

Comments

@goldpbear
Copy link
Contributor

goldpbear commented Nov 15, 2017

New place models which include rich text image content currently require two round-trips to the server to save: one trip to create the place model and attachment models in the first place, and a second to update any embedded images with the S3 bucket urls returned from the first save. It would be better if we didn't need this double round trip.

To accomplish this, let's build out our Attachment model to support a type property. The type property will signal to the client the intended use of the attachment. Currently there are two use cases:

  • cover image (images that appear at the very top of place detail views, right below the title)
  • rich text embedded images (images that are embedded inside a rich text field)

The client will make use of attachments based on the value of the type field, correctly placing cover images at the top and embedded images at the appropriate point in a rich text field.

@goldpbear
Copy link
Contributor Author

@modulitos -- what do you think the prognosis is for this issue? Should I take a stab at it this week?

@modulitos
Copy link
Member

@goldpbear -- Sorry, I didn't get a chance to start on it yet :( I was planning to get to it this weekend, but feel free to work on it now and we can sync up this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants