Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rapid URL should be a config parameter (rather than hardcoded) #2438

Open
jake-low opened this issue Sep 15, 2024 · 0 comments
Open

Rapid URL should be a config parameter (rather than hardcoded) #2438

jake-low opened this issue Sep 15, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jake-low
Copy link
Contributor

As a temporary workaround for facebook/Rapid#1561, I published a hotfix to pin the Rapid version at 2.3. This required changing the MR frontend code, tagging a new version, building a new docker artifact and redeploying the service.

It would have been easier if I had chosen to make the Rapid CDN URL a configurable value when I refactored the editor integration recently (something like REACT_APP_RAPID_EDITOR_CDN_URL in .env). So I'm opening this issue to remind myself to implement that at some point. I'm not sure if it's straightforward to embed values from the config into static assets like rapid-editor.html but I think it's probably possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

1 participant