Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Tag Fix UX to make it clearer that the mapper is direcly editing OSM #2405

Open
mvexel opened this issue Aug 13, 2024 · 2 comments · May be fixed by #2482
Open

Improve Tag Fix UX to make it clearer that the mapper is direcly editing OSM #2405

mvexel opened this issue Aug 13, 2024 · 2 comments · May be fixed by #2482
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@mvexel
Copy link
Member

mvexel commented Aug 13, 2024

Inspired by this thread on the community forum.

The Tag Fix mode needs UI improvements, we need to make absolutely sure that the suggested fixes are always visible regardless of any user-defined layout or screen size. There may also be other UI hints we can provide that the action taken by the mapper directly modifies OSM.

This needs discussion before we decide on an implementation path.

@mvexel mvexel added the enhancement New feature or request label Aug 13, 2024
@mvexel mvexel pinned this issue Aug 13, 2024
@mvexel mvexel added this to the 3.17 milestone Aug 13, 2024
@mvexel
Copy link
Member Author

mvexel commented Oct 22, 2024

Discussed with @jake-low and @CollinBeczak: Let's add the details of the changes to the confirmation modal to ensure the user sees it and is fully aware that they are committing changes to the OSM map even though they have not opened an "editor". I like the idea that came up of having the user scroll (or do some other additional action) before they can confirm. But I'll leave it up to you to decide based on your experience as mappers what the best way is to convey this information.

@CollinBeczak
Copy link
Collaborator

CollinBeczak commented Oct 28, 2024

Thoughts on this design?

Example of modal before proposed change:
Screenshot 2024-10-28 at 1 52 12 PM

Example of modal after proposed change:
Screenshot 2024-10-28 at 1 52 49 PM

@CollinBeczak CollinBeczak self-assigned this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

2 participants