Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build scripts update #210

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

lightmare
Copy link
Contributor

@lightmare lightmare commented Aug 29, 2019

Notable changes

  • setup.py reads environment variables MASON_ROOT and MAPNIK_CONFIG, which can be used to override these paths; defaults remained as before
  • setup.py no longer calls bootstrap.sh; it must be explicitly called earlier
  • bootstrap.sh no longer runs postgres, createdb etc.; database initialization has been moved to scripts/setup_postgres.sh
  • mason added as git submodule; scripts/setup_mason.sh now tries to update submodule first; if that's not possible, falls back to downloading archive as before

TODO

  • amend README Building from Mason section, add command ./bootstrap.sh

Also don't run bootstrap.sh from setup.py, instead assume that Mason
and required packages have already been installed (with bootstrap.sh
or otherwise).
- git submodule update when needed
- remove unused var JOBS (it shouldn't be in "env" even if it were used,
  because changing "env" vars invalidates cache)
- install clang from apt instead of mason
- try common workaround for distutils bugs, without branching
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant