Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear spatial edges after cells have been updated #599

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Clear spatial edges after cells have been updated #599

merged 1 commit into from
Nov 15, 2023

Conversation

oscarlorentzon
Copy link
Member

Motivation

  • Do not clear spatial edges if the added data did not actually update a cell.

Contribution

  • Graph is reset after a cell has been updated but before data added event is sent.

Test Plan

yarn test
yarn start

@oscarlorentzon
fix: only clear spatial edges after update
c2552fb 
Do not clear spatial edges if the added data did not actually
upade a cell.
@oscarlorentzon oscarlorentzon added this to the v5.0.0 milestone Nov 15, 2023
@oscarlorentzon oscarlorentzon self-assigned this Nov 15, 2023
@oscarlorentzon oscarlorentzon changed the title Only clear spatial edges after update Clear spatial edges after cells have been updated Nov 15, 2023
@oscarlorentzon oscarlorentzon merged commit 5ea757a into main Nov 15, 2023
5 checks passed
@oscarlorentzon oscarlorentzon deleted the feature-data-added branch November 15, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oscarlorentzon oscarlorentzon

Labels
cla signed
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@oscarlorentzon @facebook-github-bot