Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: the ability to restore all services at once. #3

Open
Calrion opened this issue May 20, 2017 · 1 comment
Open

Feature request: the ability to restore all services at once. #3

Calrion opened this issue May 20, 2017 · 1 comment

Comments

@Calrion
Copy link

Calrion commented May 20, 2017

First of all thanks for this, it's been really handy.

I expect my tests to be independent from each other, and also to not need to cleanup after themselves. Given this, I'd like to call a single AWS.restore() (or similar) after each test runs.

Would you be interested in a PR with such a function?

Any suggestions on how you'd like to see it work? I was thinking a list of services could be maintained when stubbing, then it'd be easy enough to iterate through these calling .restore(), but I'm happy to defer to your judgment.

@sharkinsspatial
Copy link

I just encountered a similar issue as I am more accustomed to using raw Sinon stubs. I will try to submit a pull request with a sandbox option parameter that allows us to generate the mocks with a single Sinon sandbox. That will allow for simpler mock cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants