Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip BayesQuasiTest on macOS #38069

Merged

Conversation

cailafinn
Copy link
Contributor

Description of work

Summary of work

Failing due to fitting differences (probably). Skipping as there are no known macOS users for this algorithm. Should still be fixed to allow consistency, this is a temp fix only.

Purpose of work

Allow the nightly build to pass.

To test:

On Windows & Linux:

  1. Run the test using the systemtest script in the build directory.
  2. The test passes.

On macOS:

  1. Attempt to run the test using the systemtest script.
  2. The test is skipped.

This does not require release notes because there are no user-facing changes.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@cailafinn cailafinn added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Framework Issues and pull requests related to components in the Framework labels Sep 23, 2024
@cailafinn cailafinn added this to the Release 6.11 milestone Sep 23, 2024
@cailafinn cailafinn marked this pull request as ready for review September 23, 2024 11:28
@sf1919
Copy link
Contributor

sf1919 commented Sep 23, 2024

Does this need to be on release-next?

@cailafinn cailafinn changed the base branch from main to release-next September 23, 2024 13:05
Failing due to fitting differences (probably). Skipping as there are no
known macOS users for this algorithm. Should still be fixed to allow
consistency, this is a temp fix only.
Copy link
Contributor

@robertapplin robertapplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this skip. I'm not aware that Bayes Quasi is used on Mac, so we should be good to investigate this later

@RichardWaiteSTFC
Copy link
Contributor

Happy to merge this - does it need a MacOS tester or should we just see if the nightly builds on OSX?

@robertapplin
Copy link
Contributor

Happy to merge this - does it need a MacOS tester or should we just see if the nightly builds on OSX?

I believe it shouldn't need a MacOS tester because the MantidSystemTest framework handles the skipping

@RichardWaiteSTFC RichardWaiteSTFC merged commit e0d95df into mantidproject:release-next Sep 23, 2024
10 checks passed
@cailafinn cailafinn deleted the skip_macos_bayesquasi branch September 25, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Framework Issues and pull requests related to components in the Framework High Priority An issue or pull request that if not addressed is severe enough to postponse a release.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants