Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn ISIS SANS compatibility mode off by default #38057

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Turn ISIS SANS compatibility mode off by default #38057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d048e74
Set compatibility mode to be off by default
rbauststfc Sep 20, 2024
b23b975
Update compatibility mode documentation
rbauststfc Sep 20, 2024
c54339a
Add release note for issue 38053
rbauststfc Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/source/interfaces/isis_sans/Settings Tab.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,9 @@ use 8, 9, 10, 12, 14, 16, 20, 21, 22.
Compatibility Mode
""""""""""""""""""

*As of version 6.11 of Mantid, this feature is no longer enabled by default.
It should be considered deprecated and will be removed in a future release.*

The previous SANS GUI converted event-mode data to histogram-mode early into
processing. This used the time-of-flight binning parameters specified by the
user or copied the monitor binning.
Expand Down
1 change: 1 addition & 0 deletions docs/source/release/v6.11.0/SANS/New_features/38053.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- The :ref:`compatibility_mode` feature in the ISIS SANS GUI is no longer selected by default. This feature should be considered deprecated and will be removed completely in a future release.
4 changes: 2 additions & 2 deletions scripts/Interface/ui/sans_isis/sans_data_processor_window.ui
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ QGroupBox::title {
<item>
<widget class="QStackedWidget" name="main_stacked_widget">
<property name="currentIndex">
<number>0</number>
<number>1</number>
</property>
<widget class="QWidget" name="run_page">
<layout class="QVBoxLayout" name="verticalLayout_3">
Expand Down Expand Up @@ -988,7 +988,7 @@ QGroupBox::title {
<bool>true</bool>
</property>
<property name="checked">
<bool>true</bool>
<bool>false</bool>
</property>
<layout class="QGridLayout" name="gridLayout_16">
<item row="0" column="0">
Expand Down
2 changes: 1 addition & 1 deletion scripts/SANS/sans/state/StateObjects/StateCompatibility.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
class StateCompatibility(metaclass=JsonSerializable):
def __init__(self):
super(StateCompatibility, self).__init__()
self.use_compatibility_mode = True # : Bool
self.use_compatibility_mode = False # : Bool
self.use_event_slice_optimisation = False # : Bool
self.time_rebin_string = "" # Str

Expand Down
4 changes: 2 additions & 2 deletions scripts/test/SANS/gui_logic/state_gui_model_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ def test_that_default_instrument_is_NoInstrument(self):
# ------------------------------------------------------------------------------------------------------------------
# Compatibility Mode
# ------------------------------------------------------------------------------------------------------------------
def test_that_default_compatibility_mode_is_true(self):
def test_that_default_compatibility_mode_is_false(self):
state_gui_model = StateGuiModel(AllStates())
self.assertTrue(state_gui_model.compatibility_mode)
self.assertFalse(state_gui_model.compatibility_mode)

def test_that_can_set_compatibility_mode(self):
state_gui_model = StateGuiModel(AllStates())
Expand Down
Loading