Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn ISIS SANS compatibility mode off by default #38057

Conversation

rbauststfc
Copy link
Contributor

Description of work

Summary of work

The compatibility mode feature in the ISIS SANS GUI was intended to be temporary, but this wasn't revisited as intended and the feature is currently being applied by default to all SANS reductions. When reducing event data, this is causing some very small differences in the results at the extreme ranges of the q range, which is not desirable. For now it is sufficient to simply turn this feature off by default. In a future release we will look at removing it entirely.

Fixes #38053

To test:

  1. Go to Interfaces->SANS->ISIS SANS.
  2. Go to the Settings tab (from the left side of the window).
  3. The Use compatibility mode checkbox should not be selected, but should be enabled (so you should still be able to select it, if desired).

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@rbauststfc rbauststfc added SANS Issues and pull requests related to SANS ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS labels Sep 20, 2024
@rbauststfc rbauststfc added this to the Release 6.11 milestone Sep 20, 2024
@rbauststfc rbauststfc linked an issue Sep 20, 2024 that may be closed by this pull request
@rbauststfc rbauststfc force-pushed the 38053_SANS_compatibility_mode_off_by_default branch from 1c2dd9e to c54339a Compare September 20, 2024 15:04
@rbauststfc rbauststfc marked this pull request as ready for review September 20, 2024 16:17
@GuiMacielPereira GuiMacielPereira self-assigned this Sep 26, 2024
Copy link
Contributor

@GuiMacielPereira GuiMacielPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked that option of compatibility mode is disabled by default. Code is straight forward and looks good.

@SilkeSchomann SilkeSchomann self-assigned this Sep 26, 2024
@SilkeSchomann SilkeSchomann merged commit 106a8a3 into mantidproject:release-next Sep 26, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS SANS Issues and pull requests related to SANS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn ISIS SANS compatibility mode off by default
3 participants