-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix restricted suffix not working on Elwin interface. #38049
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriazalvarez
added
Bug
Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing)
ISIS Team: Spectroscopy
Issue and pull requests managed by the Spectroscopy subteam at ISIS
labels
Sep 20, 2024
GuiMacielPereira
previously approved these changes
Sep 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual testing is working as intended, the filtering of workspaces by suffix is working correctly. Code is much cleaner and unused sections (filtering by types and groups) was removed.
All good!
Co-authored-by: Gui Maciel Pereira <[email protected]>
GuiMacielPereira
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing)
ISIS Team: Spectroscopy
Issue and pull requests managed by the Spectroscopy subteam at ISIS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
Fixes #38041
Summary of work
The WorkspaceMultiSelector widget was created from the DataSelector widget, but there are many functions of the DataSelector which don't need to be used (and probably we won't need to use them in the future) and clutter the class. I have remove the workspacetype and show group properties of the table and simplify the code where possible. Additionally, the suffix was not being properly updated when initiating the class, which may be why the unrestricted setting was being ignored.
Fixes #38041.
Further detail of work
To test:
Note: this test modifies the Procesor interface settings, which is done from a Settings dialog, everytime you change a Settings, make sure to click the button
Apply
and thenOk
for the setting to change.Restrict allowed input files.. .
checkbox.Add Workspaces
. The resulting dialog should contain a table with 1 entry with the same data as that you added on step 1.Restrict allowed input files..
checkbox.Add Workspaces
, the resulting dialog should contain no data (unless the data you loaded had suffix _red or _sqw)Restrict allowed input..
is ticked. Then on Elwin tab click onAdd Workspaces
and in the resulting dialog you should see an entry with the data that you added to the ADS(irs26176..) .Restrict allowed input..
checkbox.Add Workspaces
dialog from the Elwin tab, you should still see the data that you added (irs26176...)Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.