Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restricted suffix not working on Elwin interface. #38049

Merged
merged 5 commits into from
Sep 26, 2024

Conversation

adriazalvarez
Copy link
Contributor

Description of work

Fixes #38041

Summary of work

The WorkspaceMultiSelector widget was created from the DataSelector widget, but there are many functions of the DataSelector which don't need to be used (and probably we won't need to use them in the future) and clutter the class. I have remove the workspacetype and show group properties of the table and simplify the code where possible. Additionally, the suffix was not being properly updated when initiating the class, which may be why the unrestricted setting was being ignored.

Fixes #38041.

Further detail of work

To test:

Note: this test modifies the Procesor interface settings, which is done from a Settings dialog, everytime you change a Settings, make sure to click the button Apply and then Ok for the setting to change.

  • Load any data.
  • Open Data Processor interface.
  • Click on Settings icon (cog), make sure to untick the Restrict allowed input files.. . checkbox.
  • Go to the Elwin tab, and click on Add Workspaces. The resulting dialog should contain a table with 1 entry with the same data as that you added on step 1.
  • Close the Dialog.
  • Go to Settings again, and this time tick the Restrict allowed input files.. checkbox.
  • Go to the elwin tab, click on Add Workspaces, the resulting dialog should contain no data (unless the data you loaded had suffix _red or _sqw)
  • Close the dialog and the Data Processor interface.
  • Clear the ADS.
  • Load any _red data (for example irs26176_graphite002_red from SampleData-ISIS).
  • Open the Data Processor interface, check that the Settings Restrict allowed input.. is ticked. Then on Elwin tab click on Add Workspaces and in the resulting dialog you should see an entry with the data that you added to the ADS(irs26176..) .
  • Close the dialog, and in the Settings dialog, untick again the Restrict allowed input.. checkbox.
  • Wehn opening again the Add Workspaces dialog from the Elwin tab, you should still see the data that you added (irs26176...)

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@adriazalvarez adriazalvarez added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS labels Sep 20, 2024
@adriazalvarez adriazalvarez added this to the Release 6.11 milestone Sep 20, 2024
@adriazalvarez adriazalvarez linked an issue Sep 20, 2024 that may be closed by this pull request
@adriazalvarez adriazalvarez marked this pull request as ready for review September 21, 2024 06:01
@GuiMacielPereira GuiMacielPereira self-assigned this Sep 26, 2024
Copy link
Contributor

@GuiMacielPereira GuiMacielPereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual testing is working as intended, the filtering of workspaces by suffix is working correctly. Code is much cleaner and unused sections (filtering by types and groups) was removed.

All good!

@SilkeSchomann SilkeSchomann self-assigned this Sep 26, 2024
@SilkeSchomann SilkeSchomann merged commit 9420940 into release-next Sep 26, 2024
10 checks passed
@SilkeSchomann SilkeSchomann deleted the elwin_suffix branch September 26, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Restrict input by extension not working in Elwin interface
3 participants