Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect BayesQuasi calculation #38040

Conversation

robertapplin
Copy link
Contributor

Description of work

This PR fixes a bug introduced in a recent PR (#37975), where the result workspace was not being constructed correctly after a BayesQuasi calculation using the quasielasticbayes package.

I have added a system test to so we have better test coverage for this algorithm.

There is no associated issue.

Report to: Spencer Howells

To test:

  1. Open Inelastic Bayes Fitting
  2. Go to Quasi tab
  3. Load following sample and resolution

irs26176_graphite002_red.zip

irs26173_graphite002_res.zip

  1. Click Run
  2. Plot all in the Output options section of the GUI
  3. You should get plots similiar to these two:
    image

This does not require release notes because this is a regression

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@robertapplin robertapplin added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Reported By User Issues that were found or highlighted by a user/scientist labels Sep 19, 2024
@robertapplin robertapplin added this to the Release 6.11 milestone Sep 19, 2024
@RichardWaiteSTFC RichardWaiteSTFC self-assigned this Sep 19, 2024
@robertapplin robertapplin marked this pull request as ready for review September 19, 2024 14:29
Copy link
Contributor

@RichardWaiteSTFC RichardWaiteSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the results I get look good
image
Sorry about the stacking suggestion - I assumed the lists were flat!
At least it highlighted where you needed a test - thanks for adding it!

@SilkeSchomann SilkeSchomann self-assigned this Sep 20, 2024
@SilkeSchomann SilkeSchomann merged commit b873377 into mantidproject:release-next Sep 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Reported By User Issues that were found or highlighted by a user/scientist
Projects
Status: Done
Status: Merged
Development

Successfully merging this pull request may close these issues.

3 participants