Remove workspace history workaround from binaryOpertaions

[jhaigh0]

Description of work

Previously, there was a workaround in BinaryOperations::performBinaryOpWithDouble to ensure that workspace history was preserved. This involved adding a workspace briefly to the ads in order to give it a name property.

Since the pr #37839, algorithms run with storeInADS=False should have their histories reconstructed correctly, and not need such workarounds.

I think what's now happening in the function is covered by tests added in the previous pr.

Fixes #38018

To test:

Follow instructions from issue, running test 3 from project recovery test.

This issue in particular is with workspace binary ops so you could run something like

ws = CreateSampleWorkspace()
ws *= 2

Then generate the workspace history and check it is correct. (right-click, Show History, Script to Cliboard).

This does not require release notes because added this release

---

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

• Is the code of an acceptable quality?
• Does the code conform to the coding standards?
• Are the unit tests small and test the class in isolation?
• If there is GUI work does it follow the GUI standards?
• If there are changes in the release notes then do they describe the changes appropriately?
• Do the release notes conform to the release notes guide?

Functional Tests

• Do changes function as described? Add comments below that describe the tests performed?
• Do the changes handle unexpected situations, e.g. bad input?
• Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

[robertapplin]

Thanks for fixing this so quickly! I can confirm this fixes the issue we found during manual testing. A release note isn't required because this is a regression.