Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix plot crash on negative errors #37983

Closed
wants to merge 18 commits into from

Conversation

jhaigh0
Copy link
Contributor

@jhaigh0 jhaigh0 commented Sep 17, 2024

Description of work

Fix crash in the case of plotting data with negative errors.

Instead, print a warning and turn the negative errors positive.

Fixes #37973

To test:

  • Load this data with negative errors
    BCA299_Subt_QLd_Result.zip

  • Plot Spectra with errors 6-8

  • Should see a warning printed but plot opens normally.


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@jhaigh0 jhaigh0 added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS labels Sep 17, 2024
@jhaigh0 jhaigh0 added this to the Release 6.11 milestone Sep 17, 2024
@jhaigh0 jhaigh0 changed the base branch from main to release-next September 17, 2024 12:05
@jhaigh0 jhaigh0 force-pushed the 37973_crash_on_negative_errors branch from d4a4c6f to bcebf89 Compare September 17, 2024 12:07
@jhaigh0 jhaigh0 marked this pull request as draft September 17, 2024 12:07
@jhaigh0 jhaigh0 closed this Sep 17, 2024
@jhaigh0 jhaigh0 deleted the 37973_crash_on_negative_errors branch September 17, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when plotting Quasi result data with errors
3 participants