Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase tolerance in HRPD system test due to suspected OS dependent fitting #37972

Merged

Conversation

RichardWaiteSTFC
Copy link
Contributor

Description of work

Increase tolerance in HRPD system test due to suspected OS dependent fitting - test passed on CI (linux), but seems to fail on OSX.

There is no associated issue.

To test:

(1) CI passes
(2) Test on OSX if you can?


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@RichardWaiteSTFC RichardWaiteSTFC added High Priority An issue or pull request that if not addressed is severe enough to postponse a release. Diffraction Issues and pull requests related to diffraction Powder Issues and pull requests related to powder diffraction ISIS Team: Diffraction Issue and pull requests managed by the Diffraction subteam at ISIS labels Sep 13, 2024
@RichardWaiteSTFC RichardWaiteSTFC added this to the Release 6.11 milestone Sep 13, 2024
@RichardWaiteSTFC RichardWaiteSTFC force-pushed the fix_HRPD_prompt_pulse_subtraction_system_test branch from 14034ec to 2de7b2e Compare September 13, 2024 08:12
@MohamedAlmaki
Copy link
Contributor

Tested multiple times on Windows and it is working fine

@cailafinn cailafinn self-assigned this Sep 13, 2024
@cailafinn
Copy link
Contributor

cailafinn commented Sep 13, 2024

build_packages_from_branch started here: https://builds.mantidproject.org/job/build_packages_from_branch/885/
Windows because failed to download testing data: https://builds.mantidproject.org/job/build_packages_from_branch/886/

@sf1919 sf1919 mentioned this pull request Sep 13, 2024
@sf1919
Copy link
Contributor

sf1919 commented Sep 16, 2024

Building packages from branch again here as last week's attempts failed - https://builds.mantidproject.org/job/build_packages_from_branch/887/

Copy link
Contributor

@cailafinn cailafinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All systests have passed on each OS at one point or another. Lets :shipit:

@SilkeSchomann SilkeSchomann self-assigned this Sep 16, 2024
@SilkeSchomann SilkeSchomann merged commit 4650d2c into release-next Sep 16, 2024
10 checks passed
@SilkeSchomann SilkeSchomann deleted the fix_HRPD_prompt_pulse_subtraction_system_test branch September 16, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Diffraction Issues and pull requests related to diffraction High Priority An issue or pull request that if not addressed is severe enough to postponse a release. ISIS Team: Diffraction Issue and pull requests managed by the Diffraction subteam at ISIS Powder Issues and pull requests related to powder diffraction
Projects
Status: Done
Status: Merged
Development

Successfully merging this pull request may close these issues.

5 participants