-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
37594 sliceviewer sample data order #37937
37594 sliceviewer sample data order #37937
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Warning shown when following instructions, as discussed offline this is a temporary measure, the bug is somewhere in the sliceviewer.
Just some comments about confusing index and spectrum number and a suggested change. I think this also requires a release note.
Co-authored-by: RichardWaiteSTFC <[email protected]>
@Despiix - This is a victim of changes to pre-commit. See #37960 (review) for details of the changes that went in and see if you need to modify any of your files as a result and push a new commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks for changes - maybe we can hunt this bug down during release
The base branch was changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving again after target branch changed
Description of work
Summary of work
Slice viewed displays error when sample data (Y axis) is unordered. Concluded to just displaying a warning when the unusual data is imported telling the user to order the relevant data themselves in necessary.Fixes #37594.
@robertapplinFurther detail of work
To test:
Import the attached data:
File: osiris100318-100329_graphite002_red_elwin_eq.zip
Open the Slice Viewer:
Right click the data and click "Slice Viewer"
Check for a Warning:
The window should display the data, but also show a warning message on the side.
Expected behavior: The data should appear "broken" (Thin line strip), and the warning should provide further details.
Test with Other Data:
Try importing and viewing other data files
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.