Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

37594 sliceviewer sample data order #37937

Merged
merged 5 commits into from
Sep 12, 2024

Conversation

Despiix
Copy link
Collaborator

@Despiix Despiix commented Sep 9, 2024

Description of work

Summary of work

Slice viewed displays error when sample data (Y axis) is unordered. Concluded to just displaying a warning when the unusual data is imported telling the user to order the relevant data themselves in necessary.

Fixes #37594.

@robertapplin

Further detail of work

To test:

  1. Import the attached data:
    File: osiris100318-100329_graphite002_red_elwin_eq.zip

  2. Open the Slice Viewer:
    Right click the data and click "Slice Viewer"

  3. Check for a Warning:
    The window should display the data, but also show a warning message on the side.
    Expected behavior: The data should appear "broken" (Thin line strip), and the warning should provide further details.

  4. Test with Other Data:
    Try importing and viewing other data files


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@sf1919 sf1919 added this to the Release 6.11 milestone Sep 10, 2024
@sf1919 sf1919 added ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) labels Sep 10, 2024
Copy link
Contributor

@RichardWaiteSTFC RichardWaiteSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning shown when following instructions, as discussed offline this is a temporary measure, the bug is somewhere in the sliceviewer.
Just some comments about confusing index and spectrum number and a suggested change. I think this also requires a release note.

@sf1919
Copy link
Contributor

sf1919 commented Sep 12, 2024

@Despiix - This is a victim of changes to pre-commit. See #37960 (review) for details of the changes that went in and see if you need to modify any of your files as a result and push a new commit.

Copy link
Contributor

@RichardWaiteSTFC RichardWaiteSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks for changes - maybe we can hunt this bug down during release

@SilkeSchomann SilkeSchomann self-assigned this Sep 12, 2024
@jclarkeSTFC jclarkeSTFC changed the base branch from main to release-next September 12, 2024 15:14
@jclarkeSTFC jclarkeSTFC dismissed RichardWaiteSTFC’s stale review September 12, 2024 15:14

The base branch was changed.

Copy link
Contributor

@RichardWaiteSTFC RichardWaiteSTFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again after target branch changed

@SilkeSchomann SilkeSchomann merged commit 251c8f6 into release-next Sep 12, 2024
10 checks passed
@SilkeSchomann SilkeSchomann deleted the 37594_sliceviewer_sample_data_order branch September 12, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slice Viewer indexOfValue - value out of range error
4 participants