Remove prompt pulse #37932
Remove prompt pulse #37932
Conversation
|
Don't forget to add labels and milestones please |
dmitry-ganyushin
added
the
Bug
There was a problem hiding this comment.
- Still needs release notes
- I prefer you verify visually that only low TOF/d-spacing is changed and update the reference file (docs for updating files)
|
If I set |
|
It looks like you are only running a single system test. Run the full SNSPowderRedux suite locally and you'll track down the changes faster. ninja && ./systemtest -R SNSPowderReduxAlso, you need to put the input parameters in the tests back to what they were. This is how the instrument team has been calling the code for years and it needs to stay a realistic example. The reference data needs to be inspected to see how it is changed and update the reference file. |
|
This is blocked by #37972. The Linux tests here can be re-run once it has been merged in. |
RE #37306 Co-authored-by: Yusuf Jimoh <[email protected]>
RE #37306 Co-authored-by: Yusuf Jimoh <[email protected]>
Also adds some inheritance to avoid repeats. RE #37306 Co-authored-by: Yusuf Jimoh <[email protected]>
RE #37306 Co-authored-by: Yufuf Jimoh <[email protected]>
Set test conditions as they were before change is the RemovePromptPulse
Fixed tolerance value initialization.
… as it was before the fix.
Updated a reference files
Set test conditions as they were before change is the RemovePromptPulse
Fixed tolerance value initialization.
… as it was before the fix.
Updated a reference files
dmitry-ganyushin
force-pushed
the
RemovePromptPulse
branch
from
0528afa
to
d7dad28
Compare
Description of work
6177: RemovePromptPulse doesn't work when negative time-of-flight are in the workspace
Summary of work
This PR should fix issues for RemovePromptPulse to mask correctly the first pulse including the case of ToFmin <0.