Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .pre-commit-config.yaml in release-next to match main #36780

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

robertapplin
Copy link
Contributor

@robertapplin robertapplin commented Jan 30, 2024

Description of work

Update black to the same version as on main to avoid merge conflicts

There is no associated issue.

Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@robertapplin robertapplin added the ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS label Jan 30, 2024
@robertapplin robertapplin added this to the Release 6.9 milestone Jan 30, 2024
@robertapplin robertapplin changed the title Update .pre-commit-config.yaml Update .pre-commit-config.yaml in release-next to match main Jan 30, 2024
@thomashampson thomashampson marked this pull request as ready for review January 30, 2024 15:11
@thomashampson thomashampson merged commit 41a15f2 into release-next Jan 30, 2024
3 of 4 checks passed
@thomashampson thomashampson deleted the 0-update-black-pre-commit branch January 30, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: Core Issue and pull requests managed by the Core subteam at ISIS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants