Fix string format for multiple files input in Elwin tab. #36751
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
This PR fixes a bug in the formatting of multiple files as input for the Elwin tab in the Data Manipulation interface.
On this release cycle, there's been a lot of maintenance task in indirect/inelastic tabs. One of these changed some of the
QString
types used in presenters tostd::string
types. The string manipulation for both formats is slightly different, there were two lines in the string formatting function that we didn't correct during development when we modified the type. Now is it fixed.Fixes #36725 .
Further detail of work
To test:
Data Manipulation -> Elwin tab
interface.irs26173_graphite002_red.nxs
andirs2617_graphite002_red.nxs
.Run
.Instead of this:
Reviewer
Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.Gatekeeper
If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.