Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix string format for multiple files input in Elwin tab. #36751

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

adriazalvarez
Copy link
Contributor

Description of work

This PR fixes a bug in the formatting of multiple files as input for the Elwin tab in the Data Manipulation interface.
On this release cycle, there's been a lot of maintenance task in indirect/inelastic tabs. One of these changed some of the QString types used in presenters to std::string types. The string manipulation for both formats is slightly different, there were two lines in the string formatting function that we didn't correct during development when we modified the type. Now is it fixed.

Fixes #36725 .

Further detail of work

To test:

  1. Open Data Manipulation -> Elwin tab interface.
  2. On file input, click on Browse and multi-select files: irs26173_graphite002_red.nxs and irs2617_graphite002_red.nxs.
  3. Click on Run.
  4. Check the ADS, the Output workspace names should look like this:

image

Instead of this:

image


Reviewer

Please comment on the points listed below (full description).
Your comments will be used as part of the gatekeeper process, so please comment clearly on what you have checked during your review. If changes are made to the PR during the review process then your final comment will be the most important for gatekeepers. In this comment you should make it clear why any earlier review is still valid, or confirm that all requested changes have been addressed.

Code Review

  • Is the code of an acceptable quality?
  • Does the code conform to the coding standards?
  • Are the unit tests small and test the class in isolation?
  • If there is GUI work does it follow the GUI standards?
  • If there are changes in the release notes then do they describe the changes appropriately?
  • Do the release notes conform to the release notes guide?

Functional Tests

  • Do changes function as described? Add comments below that describe the tests performed?
  • Do the changes handle unexpected situations, e.g. bad input?
  • Has the relevant (user and developer) documentation been added/updated?

Does everything look good? Mark the review as Approve. A member of @mantidproject/gatekeepers will take care of it.

Gatekeeper

If you need to request changes to a PR then please add a comment and set the review status to "Request changes". This will stop the PR from showing up in the list for other gatekeepers.

@adriazalvarez adriazalvarez added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Manual Tests Only for issues that are unscripted testing tasks during the release period labels Jan 26, 2024
@adriazalvarez adriazalvarez added this to the Release 6.9 milestone Jan 26, 2024
@sf1919 sf1919 linked an issue Jan 26, 2024 that may be closed by this pull request
@robertapplin robertapplin self-assigned this Jan 29, 2024
@robertapplin
Copy link
Contributor

Building this at the moment. Just want to check, does it need a release note?

@adriazalvarez
Copy link
Contributor Author

I think not, since this was a regression.

Copy link
Contributor

@robertapplin robertapplin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice and clean fix, happy to approve 👍

@SilkeSchomann SilkeSchomann merged commit 888a3cb into release-next Jan 29, 2024
9 checks passed
@SilkeSchomann SilkeSchomann deleted the 36725_wrong_format branch January 29, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Manual Tests Only for issues that are unscripted testing tasks during the release period
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

Wrong format of output workspace in Data Manipulation Interface
3 participants