Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate time slicing with ISIS SANS scaled background subtraction #38087

Open
rbauststfc opened this issue Sep 26, 2024 · 0 comments
Open
Assignees
Labels
Investigation A task to investigate options for future work ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS SANS Issues and pull requests related to SANS
Milestone

Comments

@rbauststfc
Copy link
Contributor

Under issue #35446 we added functionality to perform a scaled background subtraction via the ISIS SANS GUI (see https://docs.mantidproject.org/nightly/interfaces/isis_sans/Runs%20Tab.html#scaled-background-subtraction). There was some follow-on work to allow the background workspace to be specified using just the row output name, as a sort of "smart look-up" feature.

There are three realistic scenarios where a scaled background subtraction would be used:

  1. Background not sliced and sample not sliced
  2. Background not sliced and sample sliced
  3. Background sliced and sample sliced

Scenario 1

This correctly supports output names as a "smart look-up" function and there is nothing further we need to look at for this scenario.

Scenario 2

This currently does not support output names as a “smart look-up” function, but it should. This would mean adding the following logic to the existing logic for looking up matching workspaces in the ADS:

  1. Find workspace names that match the Background Workspace string + only the default suffixes (Bank, Mode, Wavelength range)

Scenario 3

For this scenario, we need to ask the wider group whether it is sufficient for people’s needs that only the first slice from the background workspace is currently subtracted from all samples (i.e. for sample slices = t0_t600, t600_t1200, t1200_t1800, then the subtraction will currently always use background t0_t600). It may be necessary (and more intuitive when using a “smart look-up”) for sample slices to instead have the corresponding background slice subtracted. However there would be complexities (scientifically at the very least) that mean any implementation of this is likely to be pretty significant.

If the decision is that we go for a change in the existing implementation of scenario 3, then we can confirm with the group that the “smart lookup” should perform the “slice matching” version of the subtraction in this case. If the decision is to stick with the current “first slice only” subtraction, then we can consider whether it may be better not to have a “smart lookup” for scenario 3 at all in order to avoid misunderstandings over what is being done.

@rbauststfc rbauststfc added SANS Issues and pull requests related to SANS ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS Investigation A task to investigate options for future work labels Sep 26, 2024
@rbauststfc rbauststfc self-assigned this Sep 26, 2024
@rbauststfc rbauststfc added this to the Release 6.12 milestone Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Investigation A task to investigate options for future work ISIS Team: LSS Issue and pull requests managed by the LSS subteam at ISIS SANS Issues and pull requests related to SANS
Projects
Status: Backlog
Development

No branches or pull requests

1 participant