Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abins2D: improve user feedback if coverage settings are invalid #38085

Open
ajjackson opened this issue Sep 26, 2024 · 0 comments
Open

Abins2D: improve user feedback if coverage settings are invalid #38085

ajjackson opened this issue Sep 26, 2024 · 0 comments
Assignees
Labels
ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS
Milestone

Comments

@ajjackson
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Abins2D allows parameters of 2D chopper spectrometers to be selected for MAPS, MARI or MERLIN; these are dispatched to the PyChop library packaged within Mantid.

If certain low-energy/high-speed settings are selected, the coverage area is zero and the data fills with NaN, breaking the broadening logic.

It would be helpful to raise a more informative error in such situations.

Describe the solution you'd like
At validation time, use PyChop to check that the instrument coverage parameters are permitted; if not, fail validation with a useful message.

Describe alternatives you've considered
Improve the error message at runtime by catching this scenario. This is still helpful, but may come after a slow calculation; early validation would be better.

@ajjackson ajjackson added the ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS label Sep 26, 2024
@ajjackson ajjackson added this to the Release 6.12 milestone Sep 26, 2024
@ajjackson ajjackson self-assigned this Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS
Projects
None yet
Development

No branches or pull requests

1 participant