Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Access Violation when opening and using multiple AddWorkspaceDialog's #36756

Closed
robertapplin opened this issue Jan 29, 2024 · 2 comments
Closed

Access Violation when opening and using multiple AddWorkspaceDialog's #36756

robertapplin opened this issue Jan 29, 2024 · 2 comments
Assignees
@robertapplin
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS
Milestone
Release 6.9

Comments

@robertapplin
Copy link
Contributor

Describe the bug
There is a bug when opening multiple AddWorkspaceDialog's from the Inelastic Data Analysis interface, Data Manipulations interface and the Fit Script Generator interface. If you close the second dialog you open and then click Add` on the first dialog, there is an access violation because the raw pointer for the dialog is now invalid.

To Reproduce

  1. Open Inelastic Data Analysis interface
  2. On any of the tabs, click Add Workspace
  3. Click Add Workspace again so that you now have two dialogs open
  4. Close the second dialog you opened
  5. Click Add on the first dialog you opened
  6. Access violation!

Expected behavior
It should be possible to open multiple dialogs without an access violation occuring

Platform/Version (please complete the following information):

  • OS: All
@robertapplin robertapplin added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS Inelastic labels Jan 29, 2024
@robertapplin robertapplin added this to the Release 6.9 milestone Jan 29, 2024
@robertapplin robertapplin self-assigned this Jan 29, 2024
@robertapplin robertapplin mentioned this issue Jan 29, 2024
Merged
@sf1919
Copy link
Contributor

sf1919 commented Jan 30, 2024

Can this now be closed?

@robertapplin
Copy link
Contributor Author

Fixed by #36624

@robertapplin robertapplin added Indirect/Inelastic Issues and pull requests related to indirect or inelastic and removed Inelastic labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robertapplin robertapplin

Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS
Projects
No open projects
Release 6.9
Status: Done
Milestone
Release 6.9
Development

No branches or pull requests
2 participants
@robertapplin @sf1919