Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing signal warning on Data Analysis Interface. #36710

Closed
adriazalvarez opened this issue Jan 24, 2024 · 5 comments
Closed

Missing signal warning on Data Analysis Interface. #36710

adriazalvarez opened this issue Jan 24, 2024 · 5 comments
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS
Milestone
Release 6.9

Comments

@adriazalvarez
Copy link
Contributor

adriazalvarez commented Jan 24, 2024 •
edited
Loading

Describe the bug

There is a QObject missing signal warning on the view of the Data Analysis interface, likely caused by the refactoring of the presenter.

To Reproduce

  1. Open workbench from conda.
  2. Open Data Analysis interface
  3. Warning should be issued on the console.

Expected behavior

The warning should not be there.

Platform/Version (please complete the following information):

  • OS: Windows10
  • OS Version:
  • Mantid Version 6.9

Additional context

Added to 6.10 milestone, as it is not a critical issue for next release.
@adriazalvarez adriazalvarez added Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS labels Jan 24, 2024
@adriazalvarez adriazalvarez added this to the Release 6.10 milestone Jan 24, 2024
@robertapplin
Copy link
Contributor

Looks like this is fixed by #36624

@adriazalvarez
Copy link
Contributor Author

Yes, probably. I'll closed it then once the other is merged.

@adriazalvarez adriazalvarez mentioned this issue Jan 29, 2024
Merged
@sf1919 sf1919 modified the milestones: Release 6.10, Release 6.9 Jan 29, 2024
@sf1919
Copy link
Contributor

sf1919 commented Jan 29, 2024

I've changed the milestone as it will go into v6.9

@sf1919
Copy link
Contributor

sf1919 commented Jan 30, 2024

Can this now be closed?

@adriazalvarez
Copy link
Contributor Author

Fixed by #36624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Issues and pull requests that are regressions or would be considered a bug by users (e.g. crashing) Indirect/Inelastic Issues and pull requests related to indirect or inelastic ISIS Team: Spectroscopy Issue and pull requests managed by the Spectroscopy subteam at ISIS
Projects
ISIS Spectroscopy
Status: Done v6.10
Release 6.9
Status: Done
Milestone
Release 6.9
Development

No branches or pull requests
3 participants
@robertapplin @sf1919 @adriazalvarez