Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#32] [Integrate] As a user, I can submit the answers for the survey #85

Merged
merged 5 commits into from
Sep 13, 2023
Merged

[#32] [Integrate] As a user, I can submit the answers for the survey #85

merged 5 commits into from
Sep 13, 2023

Conversation

manh-t
Copy link
Owner

@manh-t manh-t commented Jul 24, 2023

Close #32

What happened 👀

  • When pressing the Submit button, we call the API responses.
  • When the API is called successfully, we navigate to Survey Completion screen.
  • When the API is called unsuccessfully, we show the error.

Insight 📝

N/A

Proof Of Work 📹

Screen.Recording.2023-07-24.at.10.15.49.mov

@manh-t manh-t added this to the 0.7.0 milestone Jul 24, 2023
@manh-t manh-t requested a review from hoangmirs July 24, 2023 03:17
@manh-t manh-t self-assigned this Jul 24, 2023
@manh-t
Copy link
Owner Author

manh-t commented Jul 24, 2023 •
edited
Loading

🚀 Deployed on https://65012c0b5645fe29ff29c798--manh-react-survey.netlify.app

@manh-t manh-t temporarily deployed to pull request July 24, 2023 03:19 Inactive
@manh-t
Copy link
Owner Author

manh-t commented Jul 24, 2023 •
edited
Loading

Messages
📖 Coverage is a little low, take a look

Coverage in All Files

File Line Coverage Statement Coverage Function Coverage Branch Coverage
src/../Survey/action.ts (4/10) 40% (4/10) 40% (2/6) 33% (0/0) NaN%
src/../Complete/index.tsx (1/2) 50% (1/2) 50% (0/1) 0% (0/0) NaN%
src/../MultiInputs/index.tsx (6/11) 55% (6/11) 55% (2/5) 40% (0/0) NaN%
src/../TextArea/index.tsx (5/8) 63% (5/8) 63% (1/2) 50% (0/2) 0%
src/routes/index.tsx (4/6) 67% (4/6) 67% (0/1) 0% (0/0) NaN%
src/tests/error.ts (2/3) 67% (2/3) 67% (1/2) 50% (1/3) 33%
src/../Survey/index.ts (18/26) 69% (18/26) 69% (4/7) 57% (0/0) NaN%
src/../AppSlider/index.tsx (3/4) 75% (3/4) 75% (1/2) 50% (3/3) 100%
src/screens/Question/index.tsx (27/36) 75% (27/36) 75% (8/11) 73% (16/28) 57%
src/../Rating/index.tsx (16/20) 80% (16/20) 80% (6/6) 100% (4/13) 31%
src/../Answer/index.tsx (34/38) 89% (34/38) 89% (7/8) 88% (20/33) 61%
src/../Content/index.tsx (14/15) 93% (14/15) 93% (7/7) 100% (6/9) 67%
src/helpers/deserializer.ts (17/18) 94% (17/18) 94% (7/7) 100% (10/12) 83%
src/../MultiChoice/index.tsx (19/20) 95% (19/20) 95% (7/8) 88% (7/8) 88%
src/../v1/requestManager.ts (19/20) 95% (19/20) 95% (6/6) 100% (3/5) 60%
Other (48 more) (316/316) 100% (316/316) 100% (119/120) 99% (95/101) 94%
Total (505/553) 91% (505/553) 91% (178/199) 89% (165/217) 76%

Generated by 🚫 dangerJS against 7ac6657

@manh-t manh-t added the @0.7.0 label Jul 27, 2023
@manh-t manh-t force-pushed the feature/30-integrate-question-page branch 4 times, most recently from 8e26642 to 40ba64a Compare September 11, 2023 04:09
@manh-t manh-t force-pushed the feature/32-submit-answers-for-the-survey branch from 1ee2681 to 56044a0 Compare September 11, 2023 08:23
@manh-t manh-t temporarily deployed to pull request September 11, 2023 08:24 Inactive
@manh-t manh-t force-pushed the feature/32-submit-answers-for-the-survey branch from 56044a0 to 67a2854 Compare September 11, 2023 09:13
@manh-t manh-t temporarily deployed to pull request September 11, 2023 09:14 Inactive
@manh-t manh-t force-pushed the feature/32-submit-answers-for-the-survey branch from 67a2854 to 908abee Compare September 12, 2023 03:10
@manh-t manh-t temporarily deployed to pull request September 12, 2023 03:12 Inactive
nvminhtue
nvminhtue reviewed Sep 12, 2023
View reviewed changes
src/components/Answer/index.tsx Show resolved Hide resolved
src/components/Answer/index.tsx Outdated Show resolved Hide resolved
src/components/Answer/index.tsx Outdated Show resolved Hide resolved
src/components/MultiInputs/index.tsx Show resolved Hide resolved
src/screens/Question/index.tsx Outdated Show resolved Hide resolved
src/screens/Question/index.tsx Outdated Show resolved Hide resolved
Base automatically changed from feature/30-integrate-question-page to develop September 12, 2023 10:51
@manh-t manh-t force-pushed the feature/32-submit-answers-for-the-survey branch from 908abee to dba62af Compare September 13, 2023 02:59
@manh-t manh-t temporarily deployed to pull request September 13, 2023 03:01 Inactive
@manh-t manh-t temporarily deployed to pull request September 13, 2023 03:15 Inactive
@manh-t manh-t force-pushed the feature/32-submit-answers-for-the-survey branch from d208b13 to f968500 Compare September 13, 2023 03:19
@manh-t manh-t temporarily deployed to pull request September 13, 2023 03:21 Inactive
@manh-t manh-t temporarily deployed to pull request September 13, 2023 03:27 Inactive
@manh-t manh-t merged commit fd2de21 into develop Sep 13, 2023
4 checks passed
@manh-t manh-t deleted the feature/32-submit-answers-for-the-survey branch September 13, 2023 09:58
@manh-t manh-t mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoangmirs hoangmirs hoangmirs approved these changes

@nvminhtue nvminhtue nvminhtue approved these changes

@tyrro tyrro Awaiting requested review from tyrro tyrro is a code owner

Assignees

@manh-t manh-t

Labels
type: feature @0.7.0
Projects
None yet
Milestone
0.7.0
Development

Successfully merging this pull request may close these issues.

[Integrate] As a user, I can submit the answers for the survey
3 participants
@manh-t @hoangmirs @nvminhtue