diff --git a/src/components/Answer/index.tsx b/src/components/Answer/index.tsx index 16baa15..d2f32dd 100644 --- a/src/components/Answer/index.tsx +++ b/src/components/Answer/index.tsx @@ -67,7 +67,6 @@ const Answer = ({ question }: AnswerProps): JSX.Element => { case DisplayType.Dropdown: return ( { // TODO diff --git a/src/components/Dropdown/index.test.tsx b/src/components/Dropdown/index.test.tsx index aee601b..02715a6 100644 --- a/src/components/Dropdown/index.test.tsx +++ b/src/components/Dropdown/index.test.tsx @@ -12,7 +12,6 @@ describe('Dropdown', () => { it('renders a dropdown component', () => { const dropdownProps = { - questionId: 'question-id', items: answers, onValueChanged: () => { // Do nothing @@ -33,7 +32,6 @@ describe('Dropdown', () => { selectedValue = answer.text ?? ''; }; const dropdownProps = { - questionId: 'question-id', items: answers, onValueChanged: onValueChanged, }; diff --git a/src/components/Dropdown/index.tsx b/src/components/Dropdown/index.tsx index ba5bc47..ded9d6c 100644 --- a/src/components/Dropdown/index.tsx +++ b/src/components/Dropdown/index.tsx @@ -1,4 +1,4 @@ -import React, { useEffect, useState } from 'react'; +import React, { useState } from 'react'; import { ReactComponent as ArrowDropdown } from 'assets/images/icons/arrow-dropdown.svg'; import { Answer } from 'types/answer'; @@ -8,12 +8,11 @@ export const dropdownDataTestIds = { }; interface DropdownProps { - questionId: string; items: Answer[]; onValueChanged: (value: Answer) => void; } -const Dropdown = ({ questionId, items, onValueChanged }: DropdownProps): JSX.Element => { +const Dropdown = ({ items, onValueChanged }: DropdownProps): JSX.Element => { const [isOpen, setIsOpen] = useState(false); const [selectedValue, setSelectedValue] = useState(items[0].text); @@ -27,10 +26,6 @@ const Dropdown = ({ questionId, items, onValueChanged }: DropdownProps): JSX.Ele toggleDropdown(); }; - useEffect(() => { - setSelectedValue(items[0].text); - }, [questionId, items]); - return (
{isOpen && ( -
+
{items.map((item) => (
@@ -60,7 +60,6 @@ const QuestionScreen = (): JSX.Element => {

{currentQuestion && (
-

{currentQuestion.displayType}

)} diff --git a/src/tests/fabricator.ts b/src/tests/fabricator.ts index 65485b6..64b7e72 100644 --- a/src/tests/fabricator.ts +++ b/src/tests/fabricator.ts @@ -1,6 +1,8 @@ import { faker } from '@faker-js/faker'; import { Fabricator, sequence } from '@travelperksl/fabricator'; +import { Survey } from 'types/survey'; + export const testTypeName = faker.person.fullName(); export const testTypeAge = faker.number.int(); export const testTypeFabricator = Fabricator({ @@ -86,7 +88,7 @@ export const questionResponseFabricator = Fabricator({ }); // Models -export const surveyFabricator = Fabricator({ +export const surveyFabricator = Fabricator({ id: faker.string.uuid(), resourceType: 'survey', title: faker.string.sample(),