Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bevy 0.12 migration #93

Merged
merged 10 commits into from
Mar 5, 2024
Merged

Bevy 0.12 migration #93

merged 10 commits into from
Mar 5, 2024

Conversation

LaserWitch
Copy link
Contributor

@LaserWitch LaserWitch commented Dec 17, 2023

This effort has reached a point where examples are buildable but the asset handling doesn't actually work right yet.
Bevy 0.12 had breaking changes in parts of assets and reflection that are pretty intimately intwined with the API code. I've made a number of edits in here that were just to get things building, and not always well researched correct changes. But it does actually build against bevy 0.12 so I figure it's worth making a draft.

Includes the changes from #92 currently.

@LaserWitch
Copy link
Contributor Author

The failed checks remind me to say that I'm currently focusing on lua as I actually know how to work with it's test cases. If I get everything working there, maybe I'll try to get the rhai stuff at least building too.

@makspll makspll changed the title A shot at bevy 0.12 updating Bevy 0.12 migration Mar 5, 2024
@makspll makspll marked this pull request as ready for review March 5, 2024 23:05
@makspll
Copy link
Owner

makspll commented Mar 5, 2024

Thanks @LaserWitch! That looks good, just added the Rhai bits + commited minor changes

@makspll makspll merged commit 17cf228 into makspll:main Mar 5, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants