Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to bevy 0.14 #127

Merged
merged 20 commits into from
Sep 7, 2024
Merged

Migrate to bevy 0.14 #127

merged 20 commits into from
Sep 7, 2024

Conversation

makspll
Copy link
Owner

@makspll makspll commented Sep 7, 2024

Will fix #124

@makspll
Copy link
Owner Author

makspll commented Sep 7, 2024

I am getting stack overflows on running codegen, which is strange, I would expect proper compilation failures

@makspll
Copy link
Owner Author

makspll commented Sep 7, 2024

Oh it looks to be in the active feature computation stage which does make sense as the crate sets some features for bevy which might be out of date

@makspll
Copy link
Owner Author

makspll commented Sep 7, 2024

There seems to be a dependency loop in bevy, or at least in the way the dependncies are processed

@makspll
Copy link
Owner Author

makspll commented Sep 7, 2024

It seems to have been an issue in the way we computed dependencies, since dev dependencies were included and that lead to inifnite cycles between a crate and itself (bevy_math).

It seems we get compilation errors on bevy from new rust compiler features, so I do need to upgrade the codegen nightly version

@makspll
Copy link
Owner Author

makspll commented Sep 7, 2024

This seems to be working now, examples are working fine

@makspll makspll merged commit c2c3bda into main Sep 7, 2024
19 checks passed
@shanecelis
Copy link
Contributor

I'm positively giddy about this!

@shanecelis
Copy link
Contributor

Got a chance to kick the tires and successfully updated my project to use the main branch and bevy 0.14. No issues on my end.

@github-actions github-actions bot mentioned this pull request Nov 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for bevy 0.14
2 participants