Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change vow to split out accounting from auction logic #243

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hexonaut
Copy link
Contributor

@hexonaut hexonaut commented Dec 27, 2021

Similar to #241 this is designed to make the vow immutable going forward, but instead of using a proxy it splits things out into two contracts. Read the other PR for the reason why this is important. First step is to get this working same as before. After that we can fix things like the kiss(...) debt blocking bug.

WIP Tests are still failing and code is not complete.

Notes:

  • Compared to the proxy vow this will require updating the liquidations to use the bow instead of the vow.
  • Also, naming maybe sow is better than bow ? No reason for bow in particular it was just the first thing that came into my head.

@talbaneth
Copy link

Small note - dog.sol will need to change to use both vow and bow.
Also any UI/bot that integrates with flap (and flop) auctions will still rely on the bow address and will have to update each time it changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants