Change vow to split out accounting from auction logic #243
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #241 this is designed to make the
vow
immutable going forward, but instead of using a proxy it splits things out into two contracts. Read the other PR for the reason why this is important. First step is to get this working same as before. After that we can fix things like thekiss(...)
debt blocking bug.WIP Tests are still failing and code is not complete.
Notes:
bow
instead of thevow
.sow
is better thanbow
? No reason forbow
in particular it was just the first thing that came into my head.