Adding experimental option avoiding runtime errors #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jmrenouard
commented
Feb 8, 2024
jmrenouard
commented
- Fixing shebang
- Adding --experimental for new features
kpankonen
reviewed
Feb 9, 2024
| @@ -1,5 +1,5 @@ | |||
| #!/usr/bin/perl | |||
| # mysqltuner.pl - Version 2.5.2 | |||
| #!env perl | |||
There was a problem hiding this comment.
removing the full path breaks the shebang when using bash
$ ./mysqltuner.pl --help
-bash: ./mysqltuner.pl: env: bad interpreter: No such file or directory
$ bash --version
GNU bash, version 5.1.16(1)-release (x86_64-pc-linux-gnu)
Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
$ which env
/usr/bin/env
There was a problem hiding this comment.
why do we make such change?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.