return to initial list of metaopts

maistra · Sep 20, 2024 · a65f9b0 · a65f9b0
1 parent 3390a6f
commit a65f9b0
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/controllers/routingctrl/reconcile_resources.go b/controllers/routingctrl/reconcile_resources.go
@@ -98,11 +98,11 @@ func (r *Controller) exportService(ctx context.Context, target *unstructured.Uns
 
 func (r *Controller) propagateHostsToWatchedCR(ctx context.Context, target *unstructured.Unstructured, publicHosts, externalHosts []string) error {
 	err := unstruct.PatchWithRetry(ctx, r.Client, target, func() error {
-		// Always remove the annotations first
-		annotations.Remove(annotations.RoutingAddressesExternal(""))(target)
-		annotations.Remove(annotations.RoutingAddressesPublic(""))(target)
-
-		var metaOptions []metadata.Option
+		// Remove all existing routing addresses
+		metaOptions := []metadata.Option{
+			annotations.Remove(annotations.RoutingAddressesExternal("")),
+			annotations.Remove(annotations.RoutingAddressesPublic("")),
+		}
 
 		if len(publicHosts) > 0 {
 			metaOptions = append(metaOptions, annotations.RoutingAddressesPublic(strings.Join(publicHosts, ";")))