Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse Accessibility failure #39054

Open
5 tasks
JustinHermanM opened this issue Aug 16, 2024 · 7 comments · May be fixed by #39164
Open
5 tasks

Lighthouse Accessibility failure #39054

JustinHermanM opened this issue Aug 16, 2024 · 7 comments · May be fixed by #39164
Labels
Area: Other Developer Tools Component: Developer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.7-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch

Comments

@JustinHermanM
Copy link

Preconditions and environment

  • 2.4.7-p1
  • Chrome inspect , click on light house ,
    Nav sections fail accessibility checker

Steps to reproduce

Using Chrome with Lighthouse extension installed.
Inspect and select Lighthouse
Mode = Navigation (default)
Device = Desktop
Categories = Accessibility
Analyze page load

Expected result

Pass with Accessibility score of 100

Actual result

Accessibility score of 95
Elements with an ARIA [role] that require children to contain a specific [role] are missing some or all of those required children.
div.section-items.nav-sections-items.mage-tabs-disabled
div#store.menu.section-item-content.nav-sections-item-content

Additional information

The parent -

one of the children

I believe the child should have the role="tab" to pass Accessibility

Release note

No response

Triage and priority

  • Severity: S0 - Affects critical data or functionality and leaves users without workaround.
  • Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
  • Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
  • Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
  • Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.
Copy link

m2-assistant bot commented Aug 16, 2024

Hi @JustinHermanM. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, Add a comment to the issue:


Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

Copy link

m2-assistant bot commented Aug 19, 2024

Hi @engcom-Bravo. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).
  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue.
  • 3. Add Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
  • 4. Verify that the issue is reproducible on 2.4-develop branch
    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
  • 5. Add label Issue: Confirmed once verification is complete.
  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@engcom-Bravo engcom-Bravo added the Reported on 2.4.7-p1 Indicates original Magento version for the Issue report. label Aug 19, 2024
@engcom-Bravo
Copy link
Contributor

Hi @JustinHermanM,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is reproducible.Kindly refer the screenshots.

Steps to reproduce

  • Using Chrome with Lighthouse extension installed.
  • Inspect and select Lighthouse
  • Mode = Navigation (default)
  • Device = Desktop
  • Categories = Accessibility
  • Analyze page load
Screenshot 2024-08-20 at 12 01 49

Hence Confirming the issue.

Thanks.

@engcom-Bravo engcom-Bravo added Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Component: Developer Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Priority: P3 May be fixed according to the position in the backlog. Area: Other Developer Tools labels Aug 20, 2024
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/AC-12783 is successfully created for this GitHub issue.

Copy link

m2-assistant bot commented Aug 20, 2024

✅ Confirmed by @engcom-Bravo. Thank you for verifying the issue.
Issue Available: @engcom-Bravo, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@hostep
Copy link
Contributor

hostep commented Sep 12, 2024

@engcom-Bravo: can I ask you to increase the priority here? Because here in Europe a law will start applying from June 2025 onwards to force websites to adhere to accessibility rules.
And since Magento has only one big release scheduled before that date (version 2.4.8, in April 2025), it would be good if we can get this fixed in 2.4.8 if possible.

@engcom-Bravo engcom-Bravo added the Priority: P2 A defect with this priority could have functionality issues which are not to expectations. label Sep 13, 2024
@engcom-Bravo engcom-Bravo removed the Priority: P3 May be fixed according to the position in the backlog. label Sep 13, 2024
@Serfe-com
Copy link

@hostep you can review the fix for this issue on !39164 where we got this into 100% in accessibility on Lighthouse. You can use that MR as a patch until Magento team merges it into the core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Other Developer Tools Component: Developer Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Progress: PR in progress Reported on 2.4.7-p1 Indicates original Magento version for the Issue report. Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants