fix(tonic): allows the server to prematurely close the stream in client side streaming #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt side streaming Signed-off-by: bsbds <[email protected]>
bsbds
added a commit
to bsbds/Xline
that referenced
this pull request
Aug 15, 2024
Ref: madsim-rs/madsim#218 Signed-off-by: bsbds <[email protected]>
bsbds
added a commit
to bsbds/Xline
that referenced
this pull request
Aug 15, 2024
Ref: madsim-rs/madsim#218 Signed-off-by: bsbds <[email protected]>
bsbds
added a commit
to bsbds/Xline
that referenced
this pull request
Aug 15, 2024
Ref: madsim-rs/madsim#218 Signed-off-by: bsbds <[email protected]>
bsbds
added a commit
to bsbds/Xline
that referenced
this pull request
Aug 16, 2024
Ref: madsim-rs/madsim#218 Signed-off-by: bsbds <[email protected]>
bsbds
added a commit
to bsbds/Xline
that referenced
this pull request
Aug 19, 2024
Ref: madsim-rs/madsim#218 Signed-off-by: bsbds <[email protected]>
bsbds
added a commit
to bsbds/Xline
that referenced
this pull request
Aug 19, 2024
Ref: madsim-rs/madsim#218 Signed-off-by: bsbds <[email protected]>
bsbds
added a commit
to bsbds/Xline
that referenced
this pull request
Aug 23, 2024
Ref: madsim-rs/madsim#218 Signed-off-by: bsbds <[email protected]>
bsbds
added a commit
to bsbds/Xline
that referenced
this pull request
Aug 23, 2024
Ref: madsim-rs/madsim#218 Signed-off-by: bsbds <[email protected]>
Phoenix500526
pushed a commit
to xline-kv/Xline
that referenced
this pull request
Aug 26, 2024
Ref: madsim-rs/madsim#218 Signed-off-by: bsbds <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client uses
Grpc::client_streamingto send a stream to the server. However, in the current implementation, if the server closes the stream prematurely, the madsim channel will be closed and will return a "connection reset" error to the client. Thus, the client will never receive the response from the server. We should allow the server to close the stream before sending back the response.