Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add caveat about madsim reproducibility #130

Open
kwannoel opened this issue Mar 3, 2023 · 3 comments
Open

Docs: Add caveat about madsim reproducibility #130

kwannoel opened this issue Mar 3, 2023 · 3 comments
Assignees

Comments

@kwannoel
Copy link
Contributor

kwannoel commented Mar 3, 2023

Initially observed here: risingwavelabs/risingwave#7901

Across various build environments the behaviour of RNG in a system may change, if they use from_entropy for instance.
Or even just compilation might produce different ordering of rng writes and reads.

It should behave the same only with the same build.
For example: we can run the original binary, it should yield the same result with the same SEED.
Alternatively: Ensure build environment is the same (compiler, os, commit).

Should add some caveat about this in docs + output on how to reproduce when madsim cluster crashes.

@kwannoel
Copy link
Contributor Author

kwannoel commented Mar 3, 2023

may /assign me 😆

@wangrunji0408
Copy link
Member

Sure, it would be great to have such documents for developers. Please feel free to add them. Thanks in advance!

@kwannoel
Copy link
Contributor Author

kwannoel commented Mar 8, 2023

More specific details:

  • OS must be same.
  • Commit must be same.
  • Compiler toolchain must be same.

We can list these as some examples. I'm not sure if it's enough, maybe we can write some tests to verify 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants