-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR where I only add CI but not trying to fix them #979
Conversation
… and put ee_mumua to the sde=1 cross-section
As expected, one of the new CI is crashing. PS: I have added an additional commit to hide the crash on ee>mumua which is a crash on the MG5aMC side. (likely the same as DY+jets) and fix the ggtt which was a filename issue more than anything else. (this is a good example where this can be squashed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @oliviermattelaer some of your confusion in #984 (comment) probably came from the fact that this testsuite_only did not include the latest upstream/master. I have merged master into it now. |
Hi @oliviermattelaer as discussed, I am merging this 979 into master. Then I will merge into master #980, which includes also #984 merged into it. |
…, madgraph5#980, madgraph5#984 patches for the new CI and Source/makefile) into june24 Fix conflicts: - MG5aMC/mg5amcnlo (keep the current june24 version 4ef15cab1 i.e. current valassi_gpucpp_june24) - epochX/cudacpp/gg_tt.mad/bin/internal/banner.py (keep a debug printout)
Hi @valassi,
This is the PR where I only add the file for the new CI.
The new CI is based on the test suite of MG5aMC, and therefore the github file is kind of a copy of what we have in MG5aMC
However, this file is auto-generated (but need to be committed for github to run the CI --maybe this is not needed but then I do not know how to do it).
So if you want to edit the CI, you need to run (from the acceptance directory)
This will create/overwrite two files:
The content of those two files are related to the directory
simple_cross_check
which contains MG5aMC script and metadata for example the filesimd_cpp_eemumua_float
line starting with
#XXXXX
are metadata (title is for the comment/information of the CI, check is doing check of the expected cross-section/error/number of events)So if you add one of such file, and run the above python script, you do have one more CI, checking the cross-section for one additional case (ensuring that cross-section are stable when changing commit).
To run this locally, you need to run (on the mg5amcnlo side)
./tests/test_manager.py -P PATH_TO_CUDACPP_PLUGIN_ACCEPTANCE_DIR
And you can use all the feature of that script to filter which script you want to run.
for example if you want only
test_simd_cpp_ggtt_mixed
you can do
./tests/test_manager.py -P PATH_TO_CUDACPP_PLUGIN_ACCEPTANCE_DIR test_simd_cpp_ggtt_mixed
to do all those related to ggtt
I would propose to merge this super quickly since this starts to be a blocker for the nd_warp_used/...
(especially since this will interact with the broken CI)