Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and complete the fix for 825 in PR 850 #860

Merged
merged 20 commits into from
Jun 3, 2024
Merged

Conversation

valassi
Copy link
Member

@valassi valassi commented Jun 3, 2024

Hi @oliviermattelaer this is a PR where I test and complete your fix in PR #850 for #825 (xsec mismatch in susy_gg_tt).

Your patch is good and we should merge it. In these tests however I found that a few additions are needed, in particular the reference files for runTest.exe must be updated (the code changed after adding Ccoeff, so I would say that the old reference files were wrong, see #859).

Still in WIP for now but will be ready soon.

oliviermattelaer and others added 15 commits May 30, 2024 10:17
…pt on my O/S - three new jpg/html files

Changes to be committed:
	modified:   susy_gg_t1t1.mad/CODEGEN_mad_susy_gg_t1t1_log.txt
	new file:   susy_gg_t1t1.mad/SubProcesses/P1_gg_t1t1x/card.jpg
	new file:   susy_gg_t1t1.mad/SubProcesses/P1_gg_t1t1x/diagrams.html
	new file:   susy_gg_t1t1.mad/SubProcesses/P1_gg_t1t1x/matrix11.jpg
…grams.html and matrix*.jpg files (created if ghostscript is installed)
…es three jpg/html files generated if ghostscript is installed
… susy xsec mismatch madgraph5#825: add Ccoeff to all HelAmps.h files
… tests are now failing (madgraph5#859), probably the reference files must be updated

STARTED  AT Mon Jun  3 09:14:12 AM CEST 2024
./tput/teeThroughputX.sh -mix -hrd -makej -eemumu -ggtt -ggttg -ggttgg -gqttq -ggttggg -makeclean
ENDED(1) AT Mon Jun  3 09:35:27 AM CEST 2024 [Status=0]
./tput/teeThroughputX.sh -flt -hrd -makej -eemumu -ggtt -ggttgg -inlonly -makeclean
ENDED(2) AT Mon Jun  3 09:47:50 AM CEST 2024 [Status=0]
./tput/teeThroughputX.sh -makej -eemumu -ggtt -ggttg -gqttq -ggttgg -ggttggg -flt -bridge -makeclean
ENDED(3) AT Mon Jun  3 09:56:04 AM CEST 2024 [Status=0]
./tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -flt -rmbhst
ENDED(4) AT Mon Jun  3 09:58:53 AM CEST 2024 [Status=0]
./tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -flt -curhst
ENDED(5) AT Mon Jun  3 10:01:40 AM CEST 2024 [Status=0]
./tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -flt -common
ENDED(6) AT Mon Jun  3 10:04:34 AM CEST 2024 [Status=0]
./tput/teeThroughputX.sh -mix -hrd -makej -susyggtt -susyggt1t1 -smeftggtttt -heftggbb -makeclean
ENDED(7) AT Mon Jun  3 10:16:45 AM CEST 2024 [Status=2]

./tput/logs_susyggt1t1_mad/log_susyggt1t1_mad_f_inl0_hrd1.txt: 1 FAILED TEST
./tput/logs_susyggt1t1_mad/log_susyggt1t1_mad_d_inl0_hrd1.txt: 1 FAILED TEST
./tput/logs_susyggt1t1_mad/log_susyggt1t1_mad_m_inl0_hrd0.txt: 1 FAILED TEST
./tput/logs_susyggt1t1_mad/log_susyggt1t1_mad_f_inl0_hrd0.txt: 1 FAILED TEST
./tput/logs_susyggt1t1_mad/log_susyggt1t1_mad_d_inl0_hrd0.txt: 1 FAILED TEST
./tput/logs_susyggt1t1_mad/log_susyggt1t1_mad_m_inl0_hrd1.txt: 1 FAILED TEST
./tput/logs_susyggtt_mad/log_susyggtt_mad_f_inl0_hrd0.txt: 1 FAILED TEST
./tput/logs_susyggtt_mad/log_susyggtt_mad_d_inl0_hrd1.txt: 1 FAILED TEST
./tput/logs_susyggtt_mad/log_susyggtt_mad_m_inl0_hrd1.txt: 1 FAILED TEST
./tput/logs_susyggtt_mad/log_susyggtt_mad_d_inl0_hrd0.txt: 1 FAILED TEST
./tput/logs_susyggtt_mad/log_susyggtt_mad_m_inl0_hrd0.txt: 1 FAILED TEST
./tput/logs_susyggtt_mad/log_susyggtt_mad_f_inl0_hrd1.txt: 1 FAILED TEST
…adgraph5#825) is fixed as expected, but a SIGFPE crash in gqttq (madgraph5#845) reappears

Also still pending: missing xsec in susyggt1t1 (madgraph5#826), LHE mismatch for FPTYPE=f in heftggbb (madgraph5#833)

STARTED  AT Mon Jun  3 10:16:45 AM CEST 2024
(SM tests)
ENDED(1) AT Mon Jun  3 02:56:24 PM CEST 2024 [Status=0]
(BSM tests)
ENDED(1) AT Mon Jun  3 03:06:33 PM CEST 2024 [Status=0]

24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_eemumu_mad/log_eemumu_mad_d_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_eemumu_mad/log_eemumu_mad_f_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_eemumu_mad/log_eemumu_mad_m_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttggg_mad/log_ggttggg_mad_d_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttggg_mad/log_ggttggg_mad_f_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttggg_mad/log_ggttggg_mad_m_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttgg_mad/log_ggttgg_mad_d_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttgg_mad/log_ggttgg_mad_f_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttgg_mad/log_ggttgg_mad_m_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttg_mad/log_ggttg_mad_d_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttg_mad/log_ggttg_mad_f_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggttg_mad/log_ggttg_mad_m_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggtt_mad/log_ggtt_mad_d_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggtt_mad/log_ggtt_mad_f_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_ggtt_mad/log_ggtt_mad_m_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_gqttq_mad/log_gqttq_mad_d_inl0_hrd0.txt
16 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_gqttq_mad/log_gqttq_mad_f_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_gqttq_mad/log_gqttq_mad_m_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_heftggbb_mad/log_heftggbb_mad_d_inl0_hrd0.txt
1 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_heftggbb_mad/log_heftggbb_mad_f_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_heftggbb_mad/log_heftggbb_mad_m_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_smeftggtttt_mad/log_smeftggtttt_mad_d_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_smeftggtttt_mad/log_smeftggtttt_mad_f_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_smeftggtttt_mad/log_smeftggtttt_mad_m_inl0_hrd0.txt
0 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_susyggt1t1_mad/log_susyggt1t1_mad_d_inl0_hrd0.txt
0 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_susyggt1t1_mad/log_susyggt1t1_mad_f_inl0_hrd0.txt
0 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_susyggt1t1_mad/log_susyggt1t1_mad_m_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_susyggtt_mad/log_susyggtt_mad_d_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_susyggtt_mad/log_susyggtt_mad_f_inl0_hrd0.txt
24 /data/avalassi/GPU2023/madgraph4gpuX/epochX/cudacpp/tmad/logs_susyggtt_mad/log_susyggtt_mad_m_inl0_hrd0.txt
…ence log file for susy_gg_tt.mad (fix madgraph5#859 after adding PR#850 fix for madgraph5#825 xsec mismatch)

CUDACPP_RUNTEST_DUMPEVENTS=1 ./build.none_d_inl0_hrd0/runTest_cpp.exe
\cp ../../test/ref/dump* ../../../CODEGEN/PLUGIN/CUDACPP_SA_OUTPUT/test/ref/
\cp ../../test/ref/dump* ../../../susy_gg_tt.sa/test/ref/
…erence log file for susy_gg_t1t1.mad (fix madgraph5#859 after adding PR#850 fix for madgraph5#825 xsec mismatch)

CUDACPP_RUNTEST_DUMPEVENTS=1 ./build.none_d_inl0_hrd0/runTest_cpp.exe
\cp ../../test/ref/dump* ../../../CODEGEN/PLUGIN/CUDACPP_SA_OUTPUT/test/ref/
\cp ../../test/ref/dump* ../../../susy_gg_t1t1.sa/test/ref/
@valassi
Copy link
Member Author

valassi commented Jun 3, 2024

Note: after fixing #825 with PR #850, again a SIGFPE reappeared also in gqttq. This is what I had reported in #845. I think that most likely this is the same SIGFPE crash in rotxxx #855 and can be fixed by adding volatile in PR #857... but I will check that.

…(new reference files for susyggtt and susyggt1t1) - all ok now

./tput/allTees.sh -bsmonly |& tee pippotput1

STARTED  AT Mon Jun  3 03:50:08 PM CEST 2024
SKIP './tput/teeThroughputX.sh -mix -hrd -makej -eemumu -ggtt -ggttg -ggttgg -gqttq -ggttggg -makeclean '
ENDED(1) AT Mon Jun  3 03:50:08 PM CEST 2024 [Status=0]
SKIP './tput/teeThroughputX.sh -flt -hrd -makej -eemumu -ggtt -ggttgg -inlonly -makeclean '
ENDED(2) AT Mon Jun  3 03:50:08 PM CEST 2024 [Status=0]
SKIP './tput/teeThroughputX.sh -makej -eemumu -ggtt -ggttg -gqttq -ggttgg -ggttggg -flt -bridge -makeclean '
ENDED(3) AT Mon Jun  3 03:50:08 PM CEST 2024 [Status=0]
SKIP './tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -flt -rmbhst '
ENDED(4) AT Mon Jun  3 03:50:08 PM CEST 2024 [Status=0]
SKIP './tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -flt -curhst '
ENDED(5) AT Mon Jun  3 03:50:08 PM CEST 2024 [Status=0]
SKIP './tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -flt -common '
ENDED(6) AT Mon Jun  3 03:50:08 PM CEST 2024 [Status=0]
./tput/teeThroughputX.sh -mix -hrd -makej -susyggtt -susyggt1t1 -smeftggtttt -heftggbb -makeclean
ENDED(7) AT Mon Jun  3 04:01:43 PM CEST 2024 [Status=0]

No errors found in logs
git checkout upstream/master $(git ls-tree --name-only HEAD */CODEGEN*txt)
… logs for easier merging

git checkout upstream/master $(git ls-tree --name-only HEAD tput/logs* tmad/logs*)
@valassi
Copy link
Member Author

valassi commented Jun 3, 2024

Hi Olivier, this is now also ready for merging.It includes your #850 and complements it with an update of the susy reference files for runTest (#859), plus various other tests. Can you please have a look and approve?

I would suggest to first merge your #850 and then this one. Or I think that one can merge this directly and it will automatically close your #850 as merged.

Reminder, there are two other PRs from me ready to be reviewed and merged: PR #854 (just adding matrix.pdf files for easier visualization than ps) and PR #857 (fixing the SIGFPE crash in rotxxx by adding volatile).

Instead, I think that issues #826 (no xsec in susy_gg_t1t1) and #845 (SIGFPE crash in gqttq) are still pedning to be debugged. I think that a combination of your PR #852 and my PR #853 might fix those, but as far as I am concerned this will wait for end June.

Thanks!
Andrea

@valassi valassi mentioned this pull request Jun 3, 2024
Copy link
Member

@oliviermattelaer oliviermattelaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Andrea, yes this can be merged.
(and no need to merge my PR first)

Cheers,

Olivier

@valassi valassi linked an issue Jun 3, 2024 that may be closed by this pull request
@valassi
Copy link
Member Author

valassi commented Jun 3, 2024

Thanks Olivier, merging now

@valassi valassi merged commit e935dec into madgraph5:master Jun 3, 2024
91 checks passed
valassi added a commit to valassi/madgraph4gpu that referenced this pull request Jun 3, 2024
…raph5#850 and madgraph5#860 for xsec mismatch madgraph5#825) into susy2

Fix conflicts:
	epochX/cudacpp/CODEGEN/generateAndCompare.sh
valassi added a commit to valassi/madgraph4gpu that referenced this pull request Jun 3, 2024
valassi added a commit to valassi/madgraph4gpu that referenced this pull request Jun 3, 2024
…raph5#850 and madgraph5#860 for xsec mismatch madgraph5#825) into susy

Fix conflicts:
	epochX/cudacpp/CODEGEN/generateAndCompare.sh
valassi added a commit to valassi/madgraph4gpu that referenced this pull request Jun 3, 2024
…aph5#860 and madgraph5#850 for Ccoeff madgraph5#825)

STARTED  AT Mon Jun  3 05:51:20 PM CEST 2024
./tput/teeThroughputX.sh -mix -hrd -makej -eemumu -ggtt -ggttg -ggttgg -gqttq -ggttggg -makeclean
ENDED(1) AT Mon Jun  3 06:12:34 PM CEST 2024 [Status=0]
./tput/teeThroughputX.sh -flt -hrd -makej -eemumu -ggtt -ggttgg -inlonly -makeclean
ENDED(2) AT Mon Jun  3 06:20:51 PM CEST 2024 [Status=0]
./tput/teeThroughputX.sh -makej -eemumu -ggtt -ggttg -gqttq -ggttgg -ggttggg -flt -bridge -makeclean
ENDED(3) AT Mon Jun  3 06:29:05 PM CEST 2024 [Status=0]
./tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -flt -rmbhst
ENDED(4) AT Mon Jun  3 06:31:55 PM CEST 2024 [Status=0]
./tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -flt -curhst
ENDED(5) AT Mon Jun  3 06:34:42 PM CEST 2024 [Status=0]
./tput/teeThroughputX.sh -eemumu -ggtt -ggttgg -flt -common
ENDED(6) AT Mon Jun  3 06:37:37 PM CEST 2024 [Status=0]
./tput/teeThroughputX.sh -mix -hrd -makej -susyggtt -susyggt1t1 -smeftggtttt -heftggbb -makeclean
ENDED(7) AT Mon Jun  3 06:47:12 PM CEST 2024 [Status=0]

No errors found in logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants