Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Stefan's addition of atlas and cms to the generate script #692

Merged
merged 8 commits into from
Jun 12, 2023

Conversation

valassi
Copy link
Member

@valassi valassi commented Jun 12, 2023

Hi @roiser this is a small MR that includes (and modifies, partly undoing) everything else in your MR #620 that is not going into #688. After this, your #620 can be considered merged (and I will close it).

Essentially here

  • I keep your addition of atlas and cms processes (WITHOUT FIXING THEM: there are issues)
  • I remove the ppttj* processes (I think we do not need them, and the syntax is wrong for one as add process should be added)
  • I remove the top level gitignore (as I added them to each process in Towards a worflow (extending Stefan's work on runcards) #688)

roiser and others added 8 commits June 12, 2023 10:21
In the meantime I have added many files to process-specific .gitignore in MR madgraph5#688

Revert "add gridpack files"
This reverts commit 1dc82b5.
…ppttj* processes

They are not really needed and, especially, some of them use the wrong syntax (should have add_subprocess)
…las" and "cms" process examples added by Stefan but move them to the end of the list

Note: the net effect of this MR is to add atlas and cms to the generateAndCompare.sh script, without fixing their builds
- the cms process is affected by the "unary minus" issue (madgraph5#628)
- the atlas process must be built with HRDCOD=1 because it has a modified SM with zero b mass (similar to madgraph5#616)
@valassi
Copy link
Member Author

valassi commented Jun 12, 2023

I have closed WIP MR #620 because all its commits wre either in #688 or in this #692,

@valassi
Copy link
Member Author

valassi commented Jun 12, 2023

All CI tests passed. This can be merged

@valassi valassi merged commit f24bfbd into madgraph5:master Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants