Add setting for whether to show document icon at title bar #1510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ychin
added
the
UI
ychin
force-pushed
the
customizable-document-icon-setting
branch
from
b5d3c42
to
2e87898
Compare
Don't automatically hide the icon while in transparent title bar mode, since it's a little confusing to the user. Instead, just use an extra setting for that. Also, when hiding the icon, properly hide it now by clearing it. Previously it was just making an invisible icon which was still draggable and didn't behave properly. Make sure after we set the setting it's refreshed correctly. Fix macvim-dev#1503
ychin
force-pushed
the
customizable-document-icon-setting
branch
from
2e87898
to
b872678
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't automatically hide the icon while in transparent title bar mode, since it's a little confusing to the user. Instead, just use an extra setting for that.
Also, when hiding the icon, properly hide it now by clearing it. Previously it was just making an invisible icon which was still draggable and didn't behave properly. Make sure after we set the setting it's refreshed correctly.
Fix #1503