Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Help menu searching Vim doc not working with special chars #1455

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Fix Help menu searching Vim doc not working with special chars #1455

merged 1 commit into from
Oct 28, 2023

Commits on Oct 27, 2023

  1. Fix Help menu searching Vim doc not working with special chars 

    Previously Help menu's Vim doc search did not work with special key
documentation like `<Down>` because when sending the input to Vim, Vim
interpreted `:h <Down>` as physically pressing down arrow instead of
typing the literal text in. Fix this by a somewhat manual process of
splitting the strings up and using `:execute` and string concatenation.
It's not pretty but works. Otherwise we would need to define another IPC
call to be able to pass commands to Vim without escaping commands.

Also fix up XCText utility so we don't use a predicate to wait for Vim
open/close which was previously kind of slow. The new method of just
using swizzling is much faster.
    @ychin
    ychin committed Oct 27, 2023
    Configuration menu
    Copy the full SHA
    565a8a1 View commit details
    Browse the repository at this point in the history