Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider dropping ByteString type from public API #81

Open
bnewbold opened this issue Oct 13, 2022 · 0 comments
Open

Consider dropping ByteString type from public API #81

bnewbold opened this issue Oct 13, 2022 · 0 comments

Comments

@bnewbold
Copy link
Member

I think the use of this type can be confusing to users. We should instead use AsRef in public method arguments, and simply return Vec<u8> or String (as appropriate) in return types.

We could continue using ByteString internally, if it is helpful.

Filing this issue as a placeholder and for discussion, this is not urgent, and i'm not planning to do it in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant