-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin causes crashes on iOS #102
Comments
I can't reproduce this on my android phone. |
Same problem here, with a clean vault with only this plugin and a single file. Current iOS Testflight (1.4.7 (106), APO v1.3.7). But not always. And installing Logastranza has, of course, stopped the problem recurring in that vault. In my main vault it still crashes. It looks like a resource problem: something is running out of memory or something somewhere. When it does work, switching notes is very slow - on the order of five seconds. |
On further investigation, it’s not crashing on iPad, but is taking long pauses, and “this tab is currently busy” messages and becoming unresponsive. I’ll try the “disable plugins one by one” game tomorrow. |
Just started the process by turning them all off and it crashed immediately. |
So turning off all plugins crashes it instantly? Then it doesn't seem to be an issue with the plugin but Obsidian, no? |
No, I mean even with all plugins turned off except meta-bind it crashes on phone, locks up on iPad. |
Strange. I still can't repo it on my Android phone and I don't own any Apple device, so I can't test it on one myself. Could you send me the Vault that crashes as a zip file? |
Let me have a look at reliably replicating it with a fresh vault - can’t send my main one! - and checking what happens with the release app. I’ll get what logs I can, but no console on iOS. It’ll be a few days. On 5 Aug 2023, at 10:28, Moritz Jung ***@***.***> wrote:
Strange. I still can't repo it on my Android phone and I don't own any Apple device, so I can't test it myself.
Could you send me the Vault that crashes as a zip file?
Is it possible to open the developer console on an apple device? If so, could you also send me the contents of the console?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
i am closing this due to inactivity |
I believe I may have seen this. I will report back when I have been able to get a reproduction. |
Summary: I cannot reproduce the crash when meta-bind is the only plugin enabled.
Debug info for this setup: |
And I was able to edit properties file, absolutely no problem. |
So I went back to my main vault and did the following:
Summary: So it did crash again, but after 2 restarts it was fine. |
Here is the debug info for the vault in my previous message: |
I’m guessing it’s a resource exhaustion problem, like a lot of iOS crashes seem to be - stuff crashes on my iPhone that doesn’t crash on my much more powerful iPad.
Regards,
Colman
… On 11 Dec 2023, at 17:13, Clare Macrae ***@***.***> wrote:
So I went back to my main vault and did the following:
Re-enabled Meta Bind
Opened the above note (well, the same table, but it has a bit more descriptive text)
It showed the raw markdown in Reading - couldn't get it to display the widgets
Force-quit Obsidian and restarted
Instead of showing the rendered widgets, Obsidian crashed
Restarted Obsidian (or maybe it restarted itself, I cannot remember)
Unlike when I first tried this 4 days ago, after the (second) restart, the Meta Bind widgets were displayed correctly.
Summary: So it did crash again, but after 2 restarts it was fine.
—
Reply to this email directly, view it on GitHub <#102 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACSVYMLVMW37HNKQ6NSAZ3YI45M5AVCNFSM6AAAAAAZO3YE7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJQGUYTANZWGQ>.
You are receiving this because you commented.
|
So I am guessing it is a memory limitation with lots of other active plugins. |
Yeah, the iOS wrapper looks to be bad at handling memory - it may be Metabind is leaking somewhere, I suppose, but I’m not sure how you’d fix that either, since JS should be sorting that out for you.
Regards
Colman
… On 11 Dec 2023, at 17:26, Moritz Jung ***@***.***> wrote:
So I am guessing it is a memory limitation with lots of other active plugins.
Idk if there is anything that i can do about that.
—
Reply to this email directly, view it on GitHub <#102 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACSVYLBX42OEHHQJHKTTBTYI4625AVCNFSM6AAAAAAZO3YE7SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJQGUZTCMJUG4>.
You are receiving this because you commented.
|
It seems like in the desktop app it takes around 45 MB of memory to load the plugin thanks to Mathjs. In comparison, base obsidian uses around 30 MB. |
So I have two options. Either I ignore the issue or I write my own version of a math string evaluator that is more lightweight. But that might break existing notes as i won't be able to replicate all math js features. |
A wild guess. If you are not using all of mathjs, might it be possible to have your own cut-down build of it? Also, how confident are you that memory is the issue? 45MB doesn't sound that huge to me, naively. |
From the other issue, it sounds like it is a startup issue aka when the plugin loads. And it tracks with the other things, e.g. it crashes for you only with lots of other plugins enabled. |
I’d say document that it doesn’t work well on iOS and raise an issue with the Obsidian developers. Thats not that much memory in modern terms and it shouldn’t crash like that. (Though if anyone wants stories about developing in 1k on a ZX81 I can provide.)Would disabling math in view fields on iOS help? As a config option maybe? On 11 Dec 2023, at 23:05, Moritz Jung ***@***.***> wrote:
So I have two options. Either I ignore the issue or I write my own version of a math string evaluator that is more lightweight. But that might break existing notes as i won't be able to replicate all math js features.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: ***@***.***>
|
No, as it allocates all the memory when the module gets loaded. |
Wow, it's off-topic, but how did you create that visualisation please? |
Lots of console logs from WebKit when I started to look earlier. I’d say stick a warning on the documentation and link to this issue. Not much else you can do … I’m reinstalling obsidian and syncing now to see what happens. I’ll report back if it makes a difference.On 13 Dec 2023, at 19:18, Moritz Jung ***@***.***> wrote:
According to Sigrunixia, the issue does not occur if obsidian was installed after the iOS 17.0 update. But I can't confirm that.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I can cautiously report that a fresh install of Obsidian on my iPhone is working much better than previously, allowing me to cut and paste examples from the test vault without crashing immediately. |
I think I'm missing something here... I have 50 or more plugins that are working fine on the same iPhone. So what is it about this plugin which means it's affected by the iOS 17.0 update when most others are not? |
Short answer: I don't know. Long answer: Sigrunixia made a support post for the issue on the Obsidian TTRPG discord server. |
Thank you for the reply - much appreciated. (I'm not on the TTRPG Discord server so can't read that post.) |
I can report that after the complete reinstall on iOS 17.2 I can so far do stuff with MetaBind that I would have expected to make the app completely unusable on iPhone - and changing a linked slider in a note on my iPhone now updates my desktop inside a couple of seconds. So it's certainly improved matters for me. |
A test note with 200 toggles - half linked to another note - and some of the example code is performing perfectly now. I'll do the same process on my iPad and see how that goes - on the iPad it was more causing massive slowdowns than complete crashes. |
I'm not having any problems caused by meta bind now - though I haven't extensively used it yet - but on both iPhone and iPad with up to date operating systems a delete, reinstall and sync has stopped it crashing/locking up. |
I can reproduce even after reinstalling obsidian on iOS 17 😢(had it installed since 2y +). It crashes and restarts only when I open the test note. Test note has 191 |
Does the issue still occur with only dataview and only meta bind? |
had the same mindflow and still creating that situation by changing the files. gonna edit soon |
what about only meta bind and no other plugins? |
sorry that answer do not came on the same edit, the whole crashing and slow start times on iOS, slowing the whole testing down... // edit: the file does not matter, a simple INPUT field kills it all right away ;P |
what iOS version are you using? |
Latest version, 17.2.1, that could be true. Tested with meta bind plugin as the only plugin activated and still crashes. |
When you reinstalled, did you use a clean vault? My delete/reinstall was using sync so it zapped the whole vault.Colman On 26 Dec 2023, at 16:35, scarfur ***@***.***> wrote:
what iOS version are you using? You might be running into iOS memory limitations.
Latest version, 17.2.1, that could be true. Tested with meta plugin as the only plugin activated and still crashes.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Nope just the app got deleted but thanks for warning everyone |
So did any previously created indexes etc <waves hands> get deleted? Colman On 26 Dec 2023, at 19:16, scarfur ***@***.***> wrote:
When you reinstalled, did you use a clean vault? My delete/reinstall was using sync so it zapped the whole vault.Colman On 26 Dec 2023, at 16:35, scarfur @.> wrote: what iOS version are you using? You might be running into iOS memory limitations. Latest version, 17.2.1, that could be true. Tested with meta plugin as the only plugin activated and still crashes. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.>
Nope just the app got deleted but thanks for warning everyone
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Obsidian indexed the files again yes ;) |
I am having the issue when activating the metabind plugin. On both iOS and android. |
Does the issue still occur on the latest iOS, obsidian, and plugin versions? |
No recent crashes iOS 1.5.8 |
Last time I tested it didn't seem to crash the mobile version more than the mobile version normally crashes. |
I will close this issue for now, as it seems to have fixed itself. I will reopen this if the issue reappears. |
Describe the bug
Upon loading a note that contains a meta bind field, the app crashes. If the mobile app restarts and loads that same note again, the app freezes before loading. This forces me to change the name of the .md file in iOS files, as Obsidian can not be loaded before the note with the meta bind field is deleted or renamed.
To Reproduce
Steps to reproduce the behavior:
INPUT[text:test]
Expected behavior
To not crash?
Screenshots
If applicable, add screenshots to help explain your problem.
Occurs on
iOS, iPadOS
Plugin version
Any version since 0.4.0
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: