-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflective boundaries implementation #18
Comments
Not sure if this is what you are asking: https://kalepy.readthedocs.io/en/latest/kde_api.html#reflecting-boundaries |
Your link shows an example of how to use this feature in kalepy package. |
Hi @myradio , I think you're right that the description in the paper is actually describing absorption. I'm not sure how/why this got mixed up in the paper - but thank you for pointing it out. The implementation however is actually that of reflection, which you can see here. Does that clarify things? |
Hi @lzkelley , Sorry for the delay. You are absolutely right!. Actually it is both things, right? After reflecting the data wrt the boundary as (the code you mentioned) , then you need to set to zero the pdf beyond the boundary. Thanks! |
From the JOSS,
Isn't this then absorbing boundary conditions? Or am I missing something?
The text was updated successfully, but these errors were encountered: