Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing new design using Jekyll & Bootstrap #49

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

guillaumebriday
Copy link
Member

@guillaumebriday guillaumebriday commented Oct 17, 2024

## Migrate from Middleman to Jekyll for better support

Adding .ruby-version
Converting sass to scss
Converting haml to html
Removing useless assets
Removing useless or obsolete pages
Removing useless sitemap
Update robots.txt

Also here's a new design! 💅

Before

Screenshot 2024-10-17 at 22-03-42 Lyon rb Lyon Ruby Brigade

After

Screenshot 2024-10-17 at 21-47-21 Lyon rb

</a>
</li>
</ul>
</div>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cappert cappert changed the base branch from migrate-to-jekyll to master October 21, 2024 19:01
@cappert cappert changed the title Introducing new design Introducing new design using Jekyll & Bootstrap Oct 21, 2024
@cappert cappert mentioned this pull request Oct 21, 2024
@cappert
Copy link
Member

cappert commented Oct 21, 2024

Merged the two PRs (#48) because it was easier to test that way.

@guillaumebriday
Copy link
Member Author

Merged the two PRs because it was easier to test that way.

Yep perfect, it was to ease the review! 👍

Copy link
Member

@cappert cappert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a Github Actions workflow and tested it in my fork, it should pick up the CNAME automatically.

Ran a Lighthouse automated audit and got very good results (except from the Youtube embed but we can't do anything about that).

Love the new design !

- name: Checkout
uses: actions/checkout@v4
- name: Setup Ruby
uses: ruby/setup-ruby@v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might want to use a commit hash (to lock ruby versions?)
The sample workflow Github provided had an very old hash so I used the v1 version which is basically "latest"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants