-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing new design using Jekyll & Bootstrap #49
base: main
Are you sure you want to change the base?
Conversation
</a> | ||
</li> | ||
</ul> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rajouter lien : https://forms.gle/gA2Cko64qP6kLQvX8
Merged the two PRs (#48) because it was easier to test that way. |
Yep perfect, it was to ease the review! 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a Github Actions workflow and tested it in my fork, it should pick up the CNAME automatically.
Ran a Lighthouse automated audit and got very good results (except from the Youtube embed but we can't do anything about that).
Love the new design !
- name: Checkout | ||
uses: actions/checkout@v4 | ||
- name: Setup Ruby | ||
uses: ruby/setup-ruby@v1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we might want to use a commit hash (to lock ruby versions?)
The sample workflow Github provided had an very old hash so I used the v1 version which is basically "latest"
## Migrate from Middleman to Jekyll for better support
Adding .ruby-version
Converting sass to scss
Converting haml to html
Removing useless assets
Removing useless or obsolete pages
Removing useless sitemap
Update robots.txt
Also here's a new design! 💅
Before
After