Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixup sampleImage #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixup sampleImage #75

wants to merge 1 commit into from

Conversation

wuzhengu
Copy link

@wuzhengu wuzhengu commented Jun 2, 2021

No description provided.

@LeGoffMael
Copy link

thank you for this PR, fixed an issue on android where cropped image were much smaller than the provided preferredSize

-> BEFORE PR
I/flutter (21330): (preferredSize:1280)
I/flutter (19778): Cropped result: Size=Size(511.0, 640.0) MB=0.18299484252929688

-> AFTER PR
I/flutter (21330): (preferredSize:1280)
I/flutter (21330): Cropped result: Size=Size(1023.0, 1280.0) MB=0.6427774429321289

@LeGoffMael LeGoffMael mentioned this pull request Mar 3, 2023
Open
LeGoffMael added a commit to LeGoffMael/insta_assets_picker that referenced this pull request Mar 3, 2023
@LeGoffMael
change: replace image_crop package by insta_assets_crop
fd9d40b 
- Include sample image size fix on android in image_crop (lykhonis/image_crop#75)
- Rename `InstaAssetsCrop` into `InstaAssetsCropData` to avoid conflict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wuzhengu @LeGoffMael